Geoffrey McRae
f352463d19
[client] spice: obey input:grabKeyboard
2021-01-08 20:13:41 +11:00
Geoffrey McRae
2789e73296
[client] spice: added new input:autoCapture
mode
...
This new mode if enabled (disabled by default) will cause the client to
attempt to hold onto the mouse when a title/game has it captured in the
guest. This is best effort and is not a replacement for full capture
mode.
2021-01-08 19:41:10 +11:00
Geoffrey McRae
6c8eba5f54
[client] spice: rewrite cursor handling code to take advantage of xinput
2021-01-08 15:37:40 +11:00
Geoffrey McRae
6030d2f189
[client] spice: filter out events that have < 2 axis
...
This prevents the mouse wheel from being treated as a cursor movement
2021-01-08 08:42:19 +11:00
Geoffrey McRae
2788394631
[client] all: use nanosleep instead of usleep for better precision
2021-01-08 08:27:12 +11:00
Geoffrey McRae
b0f2a2e39f
[client] spice: flag the cursor as inView unconditionally in capture
2021-01-08 03:27:03 +11:00
Geoffrey McRae
526572c9c9
[client] added new feature input:rawMouse for RAW mouse input
...
This option allows those that want it (gamers) to bypass all X11 mouse
acceleration and smoothing giving true 1:1 input to the guest while in
capture mode. Note: only supported for X11!
2021-01-08 03:12:42 +11:00
Geoffrey McRae
c99561c2ac
[client] spice: filter out duplicate X xinput events
2021-01-08 02:52:47 +11:00
Geoffrey McRae
62f59ce50d
[client] spice: don't use the raw data values for raw input
...
While using the RAW movement data sounds like a good idea the user
experience is quite bad as the mouse acceleration between host and guest
changes entering capture mode. This change alters this behaviour to use
the values after processing by the X server while retaining the simpler
code path for capture mode.
2021-01-08 02:04:30 +11:00
Geoffrey McRae
fb9cf6cfbc
[client] spice: apply sensitivity when in raw capture mode
2021-01-08 01:01:53 +11:00
Geoffrey McRae
974b409e91
[client] spice: x11 use xinput2 raw mode if possible for captured mouse
2021-01-08 00:44:15 +11:00
Geoffrey McRae
27a5a0811b
[client] spice: detect end of warp based on serial and x & y match
...
x11 serials are per server command, not per event, as such several
events may be processed by the server before a new event is received
causing the existing logic to fail. This changes the logic to check for
a larger serial instead of an exact match, and confirms the completion
of the warp by matching the target x/y.
2021-01-08 00:07:43 +11:00
Geoffrey McRae
d6bb518992
[client] spice: refactor g_cursor.last to g_cursor.pos
2021-01-07 02:16:55 +11:00
Geoffrey McRae
026251cfd9
[client] spice: fix reversed warp offset math and incorrect lookbehind
2021-01-07 02:05:47 +11:00
Geoffrey McRae
9b309db964
[client] spice: general improvements to cursor warp logic
...
Previously only up to two pending warp requests were possible, this
changes this so that additional warps can be queued if the cursor's
delta has moved more then 50px between each warp request.
The old code also had an error where it would null out any additional
movement since the warp was requested, but before it was processed, this
has been corrected.
2021-01-06 22:11:28 +11:00
Geoffrey McRae
271276a0a9
[client] ll: add new method ll_peek_tail
2021-01-06 22:11:10 +11:00
Geoffrey McRae
67022d664f
[client] spice: look for x11 warp completion events in key/btn events.
2021-01-06 20:17:52 +11:00
Geoffrey McRae
09e02b0613
[client] spice: prevent the cursor from escaping while captured
2021-01-06 08:35:13 +11:00
Geoffrey McRae
e70f585cfc
[client] spice: fix rounding issue causing entry->exit in the same event
...
This fixes an issue where the warp to center could break as the user
moves their cursor slowly over one of the bottom or right edges of the
screen while it's letterboxed.
2021-01-06 08:34:14 +11:00
Geoffrey McRae
d2d6ecd1c1
[client] spice: always flush XWarpPointer calls
2021-01-05 11:53:42 +11:00
Geoffrey McRae
6f99280fe3
[client] fix the warp logic to account for still pending warps to finish
...
As X11 is a server/client protocol, issuing commands such as
XWarpPointer do not happen immediately, as such we need to identify when
the warp is complete to know to null out the movement. To do this we
track each warp issued and look for it's completion in the event filter.
As some events come in via XInput2 we need to also make use of this
instead of just relying on MotionNotify, as such the support has been
implemented for XI_Motion events.
2021-01-05 11:47:17 +11:00
Geoffrey McRae
18e84c88a0
[client] ll: fix failure to properly track the list size
2021-01-05 11:42:26 +11:00
Geoffrey McRae
25d370ef22
[client] move new scaling variables into the CursorState struct
2021-01-05 09:48:30 +11:00
Geoffrey McRae
6c12990d26
[client] print out the client version too when there is a mismatch
2021-01-05 09:18:40 +11:00
Geoffrey McRae
12c83e82bb
[client] if the host version doesn't match wait for it to be upgraded
...
This change allows one to upgrade the host application using the LG
spice client instead of immediately terminating
2021-01-05 09:13:54 +11:00
Quantum
a172d79f66
spice: scale mouse input based on host DPI information
2021-01-05 09:03:29 +11:00
Geoffrey McRae
523accf348
[client] spice: don't rely on the cursor position when it's not visible
...
DXGI DesktopDuplication does not send cursor positional updates when the
cursor is hidden, this happens when dragging a window around or when a
full screen application takes/hides the cursor. If this happened at the
same time as a resolution switch we don't know where the cursor really
is anymore.
2021-01-04 19:34:10 +11:00
Geoffrey McRae
53ae0ea9f1
[client] always update positional information when new format
2021-01-04 19:16:49 +11:00
Geoffrey McRae
8fd08cdd79
[client] spice: add option to ignore the windows key
...
If active this will prevent the client from sending keyboard events for
the windows key. The idea is to allow people to keep the windows key
bound to their WMs default action without causing the Windows start menu
to open
2021-01-04 18:22:39 +11:00
Geoffrey McRae
33b117e732
[client] spice: add new keybinds <ScrLck>+<LWin>, <ScrLck>+<RWin>
2021-01-04 18:07:09 +11:00
Geoffrey McRae
d775ed1ddb
[client] cosmetics
2021-01-04 15:52:10 +11:00
Tudor Brindus
d997f0d18c
[client] spice: properly handle high-precision scroll wheel input
...
Some setups (e.g. Wayland) have high precision scroll wheel input, such
that the y-delta on an event may exceed 1. In these cases, scrolling up
currently gets treated as scrolling down.
This commit changes the checks to use > 0 rather than == 1.
This is the approach suggested in
https://wiki.libsdl.org/SDL_MouseWheelEvent .
2021-01-04 15:51:52 +11:00
Geoffrey McRae
3b0a98ede2
[client] spice: use xlib directly for warping
...
This change allows us to look for and filter out the warp completion
event as we can obtain and use the serial number of the warp request to
do so. This is far more elegant then the x/y match that we were doing
prior.
2021-01-04 15:40:23 +11:00
Geoffrey McRae
5d5b7b3d3c
[client] spice: just minor refactoring and commenting of code
2021-01-04 15:40:02 +11:00
Tudor Brindus
012ac950ac
[client] fix Wayland detection logic
...
$XDG_SESSION_TYPE is not guaranteed to be "wayland" when running on a
Wayland compositor. However, $WAYLAND_DISPLAY must always exist.
2021-01-04 14:43:21 +11:00
Geoffrey McRae
f7d4efe1c1
[client] spice: don't ignore all enter window events
2021-01-04 14:27:30 +11:00
Geoffrey McRae
1195a76368
[client] video: ensure that the renderer is always updated on resize
2021-01-04 13:40:03 +11:00
Geoffrey McRae
43e3999a95
[client] spice: also grab keyboard when in capture mode
2021-01-04 13:22:54 +11:00
Geoffrey McRae
bfc492421c
[client] spice: use XGrabPointer when in grab mode
...
People using high DPI mice and mouse accleration require this otherwise
the mouse can escape the window before we can warp it back.
2021-01-04 13:18:02 +11:00
Geoffrey McRae
2bc767430c
[client] spice: be more aggressive with window warp for high DPI mice
2021-01-04 12:59:14 +11:00
Geoffrey McRae
183d06f90c
[client] spice: fix borderless due to another SDL bug
...
SDL2 reports the window position as 0x0 when in borderless mode until
the window is moved or resized.
2021-01-04 12:28:35 +11:00
Geoffrey McRae
f7d7fbdb73
[client] rename state
to g_state
2021-01-04 12:06:54 +11:00
Geoffrey McRae
6878eee40a
[client] refactor cursor variables into their own global struct
2021-01-04 12:04:43 +11:00
Geoffrey McRae
c08aa8ece7
[client] spice: correct enter/leave event handling
2021-01-03 23:05:35 +11:00
Geoffrey McRae
5323d9833a
[client] spice: fix mouse warp on window focus
2021-01-03 22:59:23 +11:00
Geoffrey McRae
3b580af194
[client] spice: correct oob hotspot
2021-01-03 22:28:06 +11:00
Geoffrey McRae
29a6365107
[client] spice: correct rounding errors when reaching edges
2021-01-03 22:27:48 +11:00
Geoffrey McRae
9f495863cd
[client] spice: take into account the render rect for the new x/y pos
2021-01-03 17:42:58 +11:00
Geoffrey McRae
cd06fc251f
[client] spice: don't process cursor input when the local cursor is oob
2021-01-03 17:21:04 +11:00
Geoffrey McRae
029640f1b3
[client] spice: don't use SDLs capture mode under X11, we have our own
2021-01-03 16:31:10 +11:00
Geoffrey McRae
5064a4ecdd
[client] spice: take the cursor hotspot into account
2021-01-03 15:53:20 +11:00
Geoffrey McRae
5802bfb5eb
[client] spice: calculate the entry point delta correctly
2020-12-06 11:07:05 +11:00
Geoffrey McRae
d61d7699e5
[client] spice: stop the cursor skipping the letterboxing
2020-12-06 09:58:50 +11:00
Geoffrey McRae
80d911f040
[client] spice: fix mouse exiting when the window is letterboxed/padded
2020-12-04 20:04:06 +11:00
Geoffrey McRae
1a8dfe1cc0
[client] spice: only check for a valid position if needed
2020-12-04 17:36:08 +11:00
Geoffrey McRae
c0a3b85580
[client] spice: don't disable warp when the future cursor pos is invalid
2020-12-04 17:32:28 +11:00
Geoffrey McRae
265b4544ef
[client] spice: adjust ordering to avoid dropping mouse input events
2020-12-04 01:40:29 +11:00
Geoffrey McRae
c5befbba0e
[client] spice: don't scale mouse if it's 1:1
2020-12-04 00:50:27 +11:00
Geoffrey McRae
3df23d6b73
[client] reworked the mouse tracking logic
2020-12-04 00:32:28 +11:00
Geoffrey McRae
e57f084c93
[client] added streaming clipboard support for large transfers
2020-12-03 12:01:51 +11:00
Geoffrey McRae
301ba45f0f
[client] don't grab keyboard if spice input is disabled
2020-12-01 10:03:20 +11:00
Geoffrey McRae
bbcaaccdcc
[client] added new option input:grabKeyboardOnFocus
2020-11-29 07:12:19 +11:00
Geoffrey McRae
dea7177d29
[client] added support for spice side/extra buttons
...
Note, QEMU must have support for these new buttons for this to have any
effect.
2020-11-28 14:59:21 +11:00
Geoffrey McRae
58dd352def
[client] set fullscreen after window creation to keep window dimensions
2020-11-28 10:19:17 +11:00
Geoffrey McRae
f36c674791
[client] always set the minimize on focus loss hint
2020-11-28 10:16:11 +11:00
Geoffrey McRae
4a823d0e4f
[client] grab the keyboard when the window has focus
2020-11-28 10:06:06 +11:00
jonpas
db51acdd8a
[client] add option to always show cursor
2020-11-16 06:48:57 +11:00
Geoffrey McRae
12da2fc0b7
[client] fixed incorrect warpState
...
Credit to @Adam in Discord VFIO #looking-glass
2020-11-09 22:24:40 +11:00
Geoffrey McRae
ed95f8863d
[client] fix divide by zero fault with fpsMin disabled (set to 0)
2020-11-08 10:58:18 +11:00
Geoffrey McRae
0badf2a84c
[all] move defines for LGMP_QUEUE_*_LEN into KVMFR.h
2020-10-30 18:48:41 +11:00
Geoffrey McRae
c8f740c34e
[client] fix usage of uninitialized time variable
2020-10-30 02:36:45 +11:00
Geoffrey McRae
4f9544d61d
[client] egl: added DMA texture support for direct upload
...
Note: This only works with the KVMFR kernel module in a VM->VM
configuration. If this causes issues it can be disabled with the new
option `app:allowDMA`
2020-10-30 02:36:45 +11:00
Geoffrey McRae
0bf73d862d
[client] added initial framework for dma buffer support
2020-10-30 02:36:45 +11:00
Ali Abdel-Qader
5081c3ea88
convert clipboard data type variable to Looking Glass enum before passing it to function
2020-10-29 13:46:14 +11:00
Ali Abdel-Qader
3284431785
change 'frameCount' to be atomic
2020-10-29 13:46:14 +11:00
Geoffrey McRae
a70858aea0
[client] reworked frame timing waits for better responsiveness
2020-10-26 18:09:45 +11:00
Geoffrey McRae
e02ccd7c6f
[client] fix transposed tsDiff arguments
2020-10-26 13:09:47 +11:00
Geoffrey McRae
0684ff401f
[client] fix race with call to on_restart
2020-10-14 19:40:20 +11:00
Geoffrey McRae
757a90a643
[client] add new keybind to toggle the video stream (ScrLck+V)
2020-10-14 19:32:21 +11:00
Geoffrey McRae
46df25bb80
[client] added new option win:dontUpscale
2020-10-12 23:27:33 +11:00
Geoffrey McRae
58ba76a27f
[client] seperate frame setup and data events
2020-10-12 19:43:29 +11:00
Geoffrey McRae
b2961c7939
[all] added new format version field to frame header
2020-10-12 18:52:37 +11:00
Geoffrey McRae
9c6bd888fd
[host/client] added experimental RGBA16 float support (EGL only)
2020-10-11 19:22:31 +11:00
Jonathan Rubenstein
66df00cee2
Add option to skip splash screen fade out
2020-10-09 03:28:58 +11:00
Geoffrey McRae
e6c88a4af3
[all] be smarter about getting the git version
2020-10-09 02:17:20 +11:00
Geoffrey McRae
8692e9af80
[client] don't hide the cursor when SPICE is disabled
...
Fixes #304
2020-08-21 15:40:22 +10:00
Geoffrey McRae
7d2b39058c
[client] ensure the cursor is updated when the window looses/gains focus
2020-08-20 16:05:55 +10:00
Geoffrey McRae
6927dbecd2
[client] added new input:mouseRedraw option
...
This new option, when enabled (the default) enables cursor movements to
trigger frame updates in the client, improving responsiveness at the
cost of increased FPS while the mouse is moving around.
2020-08-20 15:50:33 +10:00
Geoffrey McRae
f9b6dcc986
[client] only resync the timer if we got an early frame
...
This prevents a slow update (ie, 30ups) from pulling the refresh rate
below the minimum (ie, 60fps).
2020-08-20 15:18:45 +10:00
Geoffrey McRae
5c912e3c27
[client] spice: improve mouse syncronization with the host
2020-08-20 14:52:24 +10:00
Geoffrey McRae
7e362050f7
[all] update KVMFR to provide cursor hotspot information
...
This commit bumps the KVMFR protocol version as it adds additional
hotspot x & y fields to the KVMFRCursor struct. This corrects the issue
of invalid alignment of the local mouse when the shape has an offset
such as the 'I' beam.
2020-08-20 13:51:01 +10:00
Geoffrey McRae
e3f97e384b
[client] rework the start/restart logic to use an enum
2020-08-11 15:14:58 +10:00
Geoffrey McRae
bfb12c74fb
[client] be quicker at detecting restart and quieter about it
2020-08-11 14:52:22 +10:00
Geoffrey McRae
fa50b7824c
[client] fix crash on shutdown while waiting for a restart
2020-08-11 14:45:43 +10:00
Geoffrey McRae
74649ddb96
[client] gracefully restart if the host application restarts
2020-08-11 14:30:44 +10:00
Geoffrey McRae
3302d353cf
[client] always use spice mouse host mode
...
Since we only ever use offset movements as SPICE doesn't properly
support absolute x/y positional information without a virtual tablet
device (which breaks relative mode needed for capture), just always run
in this mode. This fixes an issue when the spice guest tools are
installed and the mouse fails to work when not captured.
2020-08-09 16:17:08 +10:00
Geoffrey McRae
1899d9f1da
[client] reset the frame time when we get a frame signal
...
This stops a duplicate frame rendering bug due to failure to discipline
based on the signal timing.
2020-08-09 15:55:12 +10:00
Geoffrey McRae
fb9b772db0
[client] we are getting the clock anyway, just reset the time
2020-08-09 15:54:45 +10:00
Geoffrey McRae
302b988524
[client] use atomics to track frame counts and avoid extra signals
2020-08-09 15:14:17 +10:00
Samuel Bowman
bd42445ea7
[client] add option to capture input on start
2020-07-17 08:39:32 +10:00
Geoffrey McRae
d7921c5d5f
[client] report the host version on mismatch if possible
2020-05-29 14:24:06 +10:00
Geoffrey McRae
6d296f2b44
[client] stop people running the client as root
2020-05-29 14:18:02 +10:00
Geoffrey McRae
553e2830bb
[client/host] share the host version with the client for diagnostics
2020-05-29 14:14:31 +10:00
Geoffrey McRae
08062e3fc3
[client] check for underflow when checking frame time
2020-05-22 22:02:44 +10:00
Geoffrey McRae
4441427943
[client] implemented better clock drift correction
2020-05-22 20:45:59 +10:00
Geoffrey McRae
f5da432d38
[client] put back the fps correction from drift/skew
2020-05-22 18:39:19 +10:00
Geoffrey McRae
60f665a65c
[client] more fps limiter fixes
2020-05-22 18:28:16 +10:00
Geoffrey McRae
9b6174793a
[client] revert cusror update render trigger
...
While it makes the mouse a bit nicer it causes frame skips during cursor
movement.
2020-05-22 18:16:48 +10:00
Geoffrey McRae
dedab38b99
[client] rename fpsLimit
to fpsMin
2020-05-22 18:15:17 +10:00
Geoffrey McRae
4580b18b04
[client] fix the fps limiter
2020-05-22 18:06:29 +10:00
Geoffrey McRae
88dad36449
[client] allow mouse movements to trigger render updates
...
Now EGL is lockless we can allow cursor updates to trigger frame updates
directly.
2020-05-22 18:00:18 +10:00
Geoffrey McRae
075c82b32c
[client] egl: fix context binding enabling a lock free implementation
2020-05-22 17:47:19 +10:00
Geoffrey McRae
ae2ffd0a28
[client] drop the default FPS target to 60 now that the fps is dynamic
2020-05-21 14:59:51 +10:00
Geoffrey McRae
26eea64689
[client] remove microstutter warning when using the fps display
...
This warning was added when it was thought to be the cause of the
microstutters, however this has been disproven with the latest batch of
changes.
2020-05-21 14:16:01 +10:00
Geoffrey McRae
e31f38eadc
[client] allow frame updates to be triggered by a timed event
...
This is a major change to how the LG client performs it's updates. In
the past LG would operate a fixed FPS regardless of incoming update
speed and/or frequency. This change allows LG to dynamically increase
it's FPS in order to better sync with the guest as it's rate changes.
2020-05-21 13:41:59 +10:00
Geoffrey McRae
01bfd2e090
[client] egl: make better use of the second thread for streaming
2020-05-21 11:44:56 +10:00
Geoffrey McRae
240d0ff263
[client] add short delay to improve initial startup
2020-05-21 09:32:08 +10:00
Geoffrey McRae
3b47a4113f
[client/obs] update to use new LGMP init api
2020-05-21 09:28:41 +10:00
Geoffrey McRae
73ba325072
[client] egl: reworked the streaming texture pipeline
2020-05-19 22:03:36 +10:00
Geoffrey McRae
18cc8d7cab
[client] fix host wait logic and print more useful help
2020-05-17 11:54:07 +10:00
Geoffrey McRae
b7ca3d7e37
[client] cleanup debug output
2020-05-17 11:25:27 +10:00
Geoffrey McRae
c4bf992c0c
[client/host] added enforcement of KVMFR versioning
2020-05-17 11:13:08 +10:00
Geoffrey McRae
243efcd51a
[client] fix missing release_key_binds for mouse sensitivity bindings
2020-04-23 18:00:17 +10:00
feltcat
e3cbdd18a0
[client] add quit keybind
2020-04-23 17:57:58 +10:00
Geoffrey McRae
75bc038144
[client] removed accidental debug commit
2020-04-12 13:48:59 +10:00
Geoffrey McRae
7018a3e737
[c-host] dxgi: close the desktop on deinit
2020-04-12 13:46:56 +10:00
Geoffrey McRae
b5f4c639fd
[client] provide better mouse tracking when exiting/entering the window
2020-04-07 14:54:38 +10:00
Geoffrey McRae
95f5962186
[client] update to properly disconnect from spice
2020-02-01 14:24:23 +11:00
Geoffrey McRae
c1fd6552d2
[client] fix hang when trying to terminate an unconnected client
2020-01-27 12:25:47 +11:00
Geoffrey McRae
7b11ab04c6
[client] always update the renderer cursor state
2020-01-27 02:11:21 +11:00
Geoffrey McRae
bced5f95ff
[all] make cursor visible a flag and send it seperate to position
2020-01-27 02:07:32 +11:00
Geoffrey McRae
dcc9625803
[client] updated to use new cursor state flags
2020-01-26 17:30:16 +11:00
Geoffrey McRae
4d0f019ad5
[spice] prepare spice for external usage
2020-01-19 06:51:21 +11:00
Geoffrey McRae
e6154e685f
[client] cosmetics
2020-01-19 06:49:56 +11:00
Geoffrey McRae
2c59b5f557
[client] added checking for invalid arguments to custom string options
2020-01-19 06:48:20 +11:00
Geoffrey McRae
4746c89227
[all] moved time and locking methods to the common library
2020-01-17 14:35:08 +11:00
Geoffrey McRae
406e22a681
[client] override new behaviour in SDL 2.0.15 and disable xinput2
...
xinput2 is used to get touch interface events with the side effect of
consuming MotionNotify events which we use because of SDL2's inability
to correctly track the window size. Since we are not that intertested in
touch for our usecase, we just turn the events off again.
2020-01-13 22:21:12 +11:00
Geoffrey McRae
17e05c6fd5
[all] expose the FrameBuffer struct for correct sizeof calculations
2020-01-13 19:30:49 +11:00
Geoffrey McRae
9846762991
[all] align the frame data to the page boundary
2020-01-13 19:17:09 +11:00
Geoffrey McRae
f82a164d75
[client] enable SDL_SYSWMEVENT on X11 to work around SDL2 bugs
2020-01-13 14:03:26 +11:00
Geoffrey McRae
e554635e48
[spice] turn on TCP_QUICKACK
...
https://assets.extrahop.com/whitepapers/TCP-Optimization-Guide-by-ExtraHop.pdf
2020-01-11 16:03:28 +11:00
Geoffrey McRae
5e915dd1ff
[client] don't send mouse click events when out of view
2020-01-11 13:11:12 +11:00
Geoffrey McRae
13f55011c0
[client] don't draw the cursor if it leaves the frame
2020-01-11 12:56:46 +11:00
Geoffrey McRae
05dc713dac
[client] more cursor tweaks for better integration with the WM
2020-01-11 06:03:16 +11:00
Geoffrey McRae
80f3c7934a
[client] more cursor tweaks and some cleanup
2020-01-11 05:22:12 +11:00
Geoffrey McRae
1341bf8fbd
[client] fix mouse acceleration when in capture mode
...
SDL2 really doesn't do this well, instead I have implemented our own
capture method that allows us to maintain better client/server cursor
sync.
2020-01-11 04:53:46 +11:00
Geoffrey McRae
5b163063c3
[client] improved sync with guest cursor position
2020-01-11 03:41:44 +11:00
Geoffrey McRae
e5178793b3
[client] don't fail on invalid magic at startup
2020-01-10 18:07:18 +11:00
Geoffrey McRae
bea7c94cae
[client/c-host] updated to use new LGMP naming conventions
2020-01-10 11:01:35 +11:00
Geoffrey McRae
6f551c770c
[client] handle pointer visibility properly
2020-01-09 21:18:35 +11:00