Geoffrey McRae
bf583290a4
[client/common] restructure project in prep for full SDL removal
2021-02-21 10:31:46 +11:00
Geoffrey McRae
6f1c19b3b0
[all] improve backtrace and debugging support
2021-02-21 10:30:57 +11:00
Quantum
2973319bff
[client] opengl: remove glu dependency
...
We only use gluOrtho2D, which is trivially replaced with glOrtho, and
gluErrorString which can be replaced with a small lookup table.
2021-02-20 12:44:32 +11:00
Quantum
ec921d7f39
[client] spice: correctly ungrab keyboard when grabKeyboardOnFocus=no
...
When input:grabKeyboardOnFocus=no, exiting capture mode should ungrab
the keyboard. Otherwise, focusing the window doesn't grab the keyboard,
but toggling capture mode would leave the keyboard stuck in a grabbed
state until defocused.
2021-02-09 20:06:27 +11:00
Tudor Brindus
637a7625d2
[client] wayland: allow EGL/OpenGL vsync to be set to on
...
This effectively reverts 4bceaf5
.
Upstream ticket: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4180
Commit 941c651
makes working around the hang in LG itself not as
annoying as before.
In the future, we can bypass this entire issue by implementing our own
swapchain and listening to frame callbacks ourselves.
2021-02-09 09:12:57 +11:00
Tudor Brindus
e6ebcec689
[client] spice: don't send zero deltas for Wayland input
...
While a compositor will never send us 0-delta motion events, they can
still end up as 0-deltas post-projection, consuming QEMU buffer space
for no reason.
This should help with mouse skipping issues.
2021-02-01 11:09:46 +11:00
Quantum
25e74301be
[client] wayland: fix copying rich text into guest
...
Before this, copying rich text ends up with a lot of funky behaviour,
for example:
* copying text from Discord shows up as HTML unless pasted into a text
editor first
* copying text from Firefox shows up as the single letter h
This commit fixes all the above issues.
Due to the change in logic, we now use the first text format offered
instead of the last, which is almost certainly the preferred form.
Doing this gets us proper Unicode support, or Unicode characters would
end up as escapes of the form \uXXXX (this is used in the fallback
forms for applications without UTF-8 support).
2021-01-30 16:55:57 +11:00
Geoffrey McRae
e951aaad2d
[client] spice: fix errant keyboard grab/ungrab behaviour
2021-01-30 12:01:20 +11:00
Quantum
4fbaf18c89
[client] update host log file path
2021-01-29 15:56:01 +11:00
Geoffrey McRae
05f2305fa0
[client] correct error in variable name from last commit
2021-01-28 09:04:52 +11:00
Geoffrey McRae
b76fedeb67
[client] all: don't trigger cursor redraws if the cursor is not visible
2021-01-28 08:58:59 +11:00
Geoffrey McRae
9e96156912
[client] egl: use eglGetPlatformDisplay(EXT) if possible
2021-01-25 16:04:33 +11:00
Geoffrey McRae
837858c214
[client] prevent lgInit
from resetting the run state
...
If the renderer fails to start it sets the run state to stopped, having
lgInit where it was causes this to be reset to running triggering
invalid usage of g_state.lgmp.
2021-01-25 15:25:52 +11:00
Tudor Brindus
941c651fad
[client] unconditionally quit on second SIGINT
...
Under some circumstances, Looking Glass can hang when SIGINT'd, for
instance, if it's stuck waiting on spice I/O that won't complete because
the guest is misbehaving.
This commit provides an escape hatch for such cases, so one doesn't have
to reach for `kill -9 $(pidof looking-glass-client)`.
2021-01-25 09:39:35 +11:00
Geoffrey McRae
8caf951c41
[client] x11: don't attempt to grab the pointer on window resize
2021-01-25 09:25:01 +11:00
Geoffrey McRae
ef54e1be7f
[client] x11: add error checking around XIGrabDevice
2021-01-25 06:52:23 +11:00
Geoffrey McRae
4c1893fe20
[all] fix numerous memory leaks at application shutdown
2021-01-24 21:47:53 +11:00
Geoffrey McRae
086f73721d
[client] egl: remove accidental commit
2021-01-24 19:19:43 +11:00
Geoffrey McRae
202739c5be
[client] egl: better debug output for EGL errors
2021-01-24 13:17:11 +11:00
Geoffrey McRae
88b15cb3fe
[client] egl: nit, fix case of function name
2021-01-24 12:18:56 +11:00
Geoffrey McRae
6990d7f7e3
[client] egl: commit missed files for the last changeset
2021-01-24 12:16:39 +11:00
Geoffrey McRae
9941a4bb83
[client] egl: runtime detect support for glEGLImageTargetTexture2DOES
2021-01-24 12:06:10 +11:00
Quantum
908aa84599
[client] wayland: use acceleration in capture mode unless rawMouse
...
We are forced to use accelerated movement in regular mode as that is how the
host machine cursor moves and we want the cursors to line up (since Wayland
cannot do warps). To avoid a change in sensitivity when toggling capture
mode on/off, we should use accelerated deltas for capture mode as well,
unless the user explicitly asks for raw input with input:rawMouse.
2021-01-23 20:18:20 +11:00
Geoffrey McRae
185c7764ba
[client] spice: always show the pointer if using input:captureOnly
2021-01-21 17:36:22 +11:00
Geoffrey McRae
4113294d30
[client] spice: fix failure to ungrab the kb with captureOnly
2021-01-21 17:32:44 +11:00
Geoffrey McRae
aa92a7a90d
[client] app: fix error: ‘dataSize’ may be used uninitialized
(take 2)
2021-01-21 17:25:53 +11:00
Geoffrey McRae
c83243f22c
[client] app: fix error: ‘dataSize’ may be used uninitialized
2021-01-21 17:21:24 +11:00
Geoffrey McRae
23e883f60f
Revert "[client] sdl: move SDL specific screensaver inhibit"
...
This reverts commit afb0146d33
.
Additional handling is required to implement this properly, postpone
this for Beta 4
2021-01-21 15:58:37 +11:00
Geoffrey McRae
dcd0cb7d8e
[client] spice: release the mouse if the host stops
2021-01-21 15:39:15 +11:00
Geoffrey McRae
29ea8ecf6b
[client] app: if spice is not in use, hide the local cursor ( fixes #415 )
2021-01-21 14:17:31 +11:00
Geoffrey McRae
afb0146d33
[client] sdl: move SDL specific screensaver inhibit out of main.c
2021-01-21 14:03:05 +11:00
Quantum
3385438095
[client] wm: use correct logic for screensaver inhibition
...
Namely, we should inhibitIdle if noScreensaver is true, not the other way
around.
2021-01-21 12:14:38 +11:00
Quantum
6077dcc123
[client] spice/wayland: fix jitter when moving the cursor slowly
...
It does not make sense to accumulate fractional error in non-capture mode
as you know exactly where the cursor is supposed to be, at least on Wayland.
On Wayland, we base movements on the current guest position and desired
target position, and the accumulated errors only skew our movements.
2021-01-20 22:54:08 +11:00
Geoffrey McRae
e758f88519
[client] spice: fix failure to align and grab the pointer
2021-01-20 22:45:48 +11:00
Geoffrey McRae
3bccd9c45e
[client] spice: input:captureOnly shouldn't capture the pointer at start
2021-01-20 22:16:03 +11:00
Geoffrey McRae
947ba9bfe3
[client] spice: fix input:captureOnly support
2021-01-20 22:12:39 +11:00
Geoffrey McRae
4ca4fd35ad
[client] doc: added win:rotate
and keybind to README.md
2021-01-20 15:37:23 +11:00
Geoffrey McRae
8fa2b5f368
[client] config: make the help text for winRotate more descriptive
2021-01-20 15:35:13 +11:00
Geoffrey McRae
8cb0cbb91d
[client] doc: update README.md with new libraries and backend config
2021-01-20 15:33:56 +11:00
Geoffrey McRae
d6f39d66bf
[client] x11: xi
is now a required library for the x11
backend
2021-01-20 15:33:34 +11:00
Geoffrey McRae
ab79dae0b8
[client] cmake: fix typo in cmake configuration
2021-01-20 15:33:10 +11:00
Geoffrey McRae
ee8c883201
[client] x11: implement screensaver (un)inhibit
2021-01-20 15:24:10 +11:00
Geoffrey McRae
d1043e590a
[client] x11: register for absolute motion events while grabbed
2021-01-20 05:51:18 +11:00
Geoffrey McRae
5789a7efc0
[client] x11: fix failure to process the correct focus events
2021-01-20 05:41:33 +11:00
Geoffrey McRae
f883c630f6
[client] spice: set inView false if the focus is lost
...
Failure to do this results in loss of input on X11 as we need to be sure
the cursor is ungrabbed.
2021-01-20 05:07:55 +11:00
Geoffrey McRae
ac3333c0d2
[client] x11: switch to using XInput2 for all events and warp
...
On platforms like KDE, mixing X core events with XInput2 events causes
issues, so just switch entirely over to XInput2.
2021-01-20 04:53:43 +11:00
Geoffrey McRae
da65c47245
[client] spice: fix transposed cursor scale calculations
2021-01-20 04:53:43 +11:00
Xiretza
31ea93dd0d
[client] Fix compiler warnings about potentially uninitialized variables
...
Build failed with _FORTIFY_SOURCE enabled because the compiler couldn't
ensure the switch statements didn't hit the default arm and thus wouldn't
define the variables. Adding a statically failing assert makes sure that
all code paths either define the variables or fail early.
$ cd client
$ env CFLAGS='-O1 -D_FORTIFY_SOURCE=1' cmake -B build/
$ make -C build
[...]
client/renderers/EGL/egl.c: In function ‘egl_calc_mouse_size’:
client/renderers/EGL/egl.c:299:36: error: ‘h’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
299 | (this->mouseHeight * (1.0f / h)) * this->scaleY
| ~~~~~~^~~~
2021-01-20 03:05:30 +11:00
Geoffrey McRae
6d162cf92d
[client] spice: remove useless check, the displayserver should do this
2021-01-20 01:34:52 +11:00
Geoffrey McRae
8f07744c98
[client] don't hide the cursor unconditionally at startup
2021-01-20 01:27:38 +11:00
Geoffrey McRae
dacc573650
[client] spice: align the guest pointer to local when entering the view
2021-01-20 01:24:31 +11:00
Geoffrey McRae
555891face
[client] x11: filter out grab/ungrab focus/leave events
2021-01-20 01:21:19 +11:00
Geoffrey McRae
8e604667f9
[client] fix regression causing failure to warp when exiting the window
2021-01-20 00:52:33 +11:00
Geoffrey McRae
3774d2bfe9
[client] realign the pointer when input is re-enabled
2021-01-20 00:30:04 +11:00
Geoffrey McRae
31eafee468
[client] always show the cursor when not using spice ( fixes #409 )
2021-01-20 00:28:27 +11:00
Geoffrey McRae
2bfcfa36df
[client] all: fix regression with input disable toggle
2021-01-20 00:23:24 +11:00
Geoffrey McRae
819562d906
[client] fix keybind regression for EGL
2021-01-19 21:12:20 +11:00
Geoffrey McRae
0c8ce9daba
[client] x11: filter out duplicate button press events
2021-01-19 21:06:30 +11:00
Geoffrey McRae
c667322f25
[client] x11: cosmetic, rename device
to raw
for raw events
2021-01-19 20:47:25 +11:00
Geoffrey McRae
07c13a9d43
[client] x11: fix regression, raw event's dont give us the cursor pos
2021-01-19 20:46:12 +11:00
Geoffrey McRae
0bd1bb5075
[client] x11: removed left behind ifdef for XINPUT
2021-01-19 20:37:15 +11:00
Geoffrey McRae
f9faa0542b
[client] x11: use raw keyboard and mouse button press events
2021-01-19 20:36:43 +11:00
Geoffrey McRae
b87004c597
[client] app: ignore resize events that don't change the size
2021-01-19 20:15:12 +11:00
Quantum
2f11024db8
[client] displayserver: move screensaver handling into displayservers
...
This also makes Wayland idle inhibition respect noScreensaver setting.
2021-01-19 19:58:11 +11:00
Tudor Brindus
44a949f5c6
[client] wayland: inhibit idle while Looking Glass has keyboard focus
2021-01-19 07:03:50 +11:00
Tudor Brindus
bf5602b062
[cmake] wayland: build idle-inhibit-unstable-v1 header
2021-01-19 07:03:50 +11:00
Geoffrey McRae
6005006dd4
[client] dont show the pointer at launch unless it really should be
2021-01-19 06:00:59 +11:00
Geoffrey McRae
b2ac2980d5
[client] don't attempt to align to the guest with invalid pos data
2021-01-19 05:56:40 +11:00
Geoffrey McRae
1da24af6ee
[client] mouse: do not warp the cursor if it's outside the window
2021-01-19 05:38:25 +11:00
Geoffrey McRae
16f88a5285
[client] x11: don't care if SDL has XInput support anymore
...
As the X11 code is all self contained now and can be disabled at
configure time there is no longer any need to check if SDL has X11
XInput support.
2021-01-19 05:30:25 +11:00
Geoffrey McRae
85ee6737d5
[client] x11: implement keyboard event handing via xinput
2021-01-19 05:01:19 +11:00
Geoffrey McRae
dfe327301d
[client] spice: do not allow the inView to be set if mouse buttons held
...
When using the meta resize feautre the cursor is over the client window,
and as such the application continues to receive motion events. This
causes the window size to spaz out.
2021-01-19 04:40:31 +11:00
Geoffrey McRae
b92e547d91
[client] egl: force the use of nearest if needed
...
As the screen output rotation can be changed on the fly, if it has been
rotated to 90 or 270 the nearest flag will be incorrect, so we perform
this check here and override the provided value.
2021-01-19 04:26:59 +11:00
Geoffrey McRae
083deff489
[client] add keybind <ScrollLock+R> to rotate the display at runtime
2021-01-19 03:49:09 +11:00
Geoffrey McRae
0451ec237e
[client] spice: add not subtract to the rotation
2021-01-19 03:44:36 +11:00
Geoffrey McRae
d2458ff5d3
[client] retain backwards compatibillity for the capture keycode
...
This is an ugly hack for now that will get us over the line for Beta 3,
after which will need to be addressed and people will need to be
informed that their configured escape key will have changed.
2021-01-19 03:08:56 +11:00
Geoffrey McRae
8a1578230f
[client] all: properly support guest rotation
...
If the guest has it's output rotated (ie, landscape) we must rotate and
translate the pointer draw location, as well as all the translations of
cursor coordinate spaces based on the rotation, along with any local
rotations that may also be applied.
2021-01-19 02:54:56 +11:00
Geoffrey McRae
733bbf5153
[client] app: rename up,right,down,left rotation to 0,90,180,270
2021-01-19 02:53:47 +11:00
Quantum
ff1dc32efe
[client] spice/wayland: fix capture mode relative movement
...
It appears that Wayland pointer motion handlers are called even when relative
mouse mode is enabled. The events they generate break first-person games.
This commit disables those handlers when relative mouse is enabled.
2021-01-19 02:50:24 +11:00
Tudor Brindus
3935acf8a5
[client] add a SDL2 to uapi scancode table
2021-01-19 02:49:51 +11:00
Tudor Brindus
04908c3290
[client] add a uapi to PS/2 scancode table
...
This table was codegen'd from uapi/linux/input-event-codes.h and SDL's
events/scancodes_linux.h.
2021-01-19 02:49:51 +11:00
Tudor Brindus
7ae487057f
[client] wayland: implement key handling
2021-01-19 02:49:51 +11:00
Tudor Brindus
1f943fbbab
[client] use uapi keybindings internally
...
This commit moves SDL to uapi mapping to the SDL backend.
2021-01-19 02:49:51 +11:00
Tudor Brindus
36b70779b9
[client] app: move SDL key event handling out of main.c
2021-01-19 02:49:51 +11:00
Tudor Brindus
7c9b273f70
[client] app: add and expose app_handleKeyPress and app_handleKeyRelease
2021-01-19 02:49:51 +11:00
Geoffrey McRae
7355c196ba
[client] remove YUV420 support
2021-01-18 13:56:44 +11:00
Tudor Brindus
842bb59955
[client] wayland: do not fall back on SDL for scroll events
2021-01-17 17:58:32 +11:00
Tudor Brindus
e7132f757e
[client] wayland: do not fall back on SDL for button events
2021-01-17 17:03:24 +11:00
Quantum
d77da1ffc7
[client] wayland: clip desired guest cursor position
...
This avoids putting internal coordinates out of screen and causing cursor
spasms while dragging beyond the edge.
2021-01-17 16:31:33 +11:00
Geoffrey McRae
d22124519e
[client] mouse: dont leave the window if any mouse buttons are held
2021-01-17 15:13:45 +11:00
Geoffrey McRae
bab7eba7f0
[client] x11: prevent default mouse button/wheel handling by SDL
2021-01-17 14:38:31 +11:00
Geoffrey McRae
41a0cfe516
[client] app: move SDL mouse event handling out of main.c
2021-01-17 14:28:50 +11:00
Geoffrey McRae
a1069ddffa
[client] x11: use XInput for button events if possible
2021-01-17 14:24:42 +11:00
Geoffrey McRae
e106f2096b
[client] app: add and expose new app_handleButtonPress/Release methods
2021-01-17 14:23:51 +11:00
Geoffrey McRae
570abeda52
[client] app: move SDL window event handing out of main.c
2021-01-17 13:42:52 +11:00
Geoffrey McRae
31c42e3676
[client] app: add new app_handleCloseEvent for displayserver backends
2021-01-17 13:42:52 +11:00
Geoffrey McRae
89a6686349
[client] app: always call the default eventFilter for unhandled events
...
This change allows much of the SDL code to be moved into the SDL
displayserver implementation.
2021-01-17 13:42:52 +11:00
Geoffrey McRae
076ed1180f
[client] app: expose app_handleFocusEvent to displayservers
2021-01-17 13:42:52 +11:00
Geoffrey McRae
e23d536af5
[client] mouse: correct issues with cursor alignment on enter/exit/focus
2021-01-17 12:53:55 +11:00
Geoffrey McRae
76182bbeb8
[client] mouse: do not send mouse updates to the guest if not focused
2021-01-17 10:44:30 +11:00