Aaron Kimbrell c96a771655 fix(buffs): remove equipment buffs with bFromUnEquip on unequip ...

Unequipping an item uncasts its equip skills; ApplyBuffBehavior::UnCast
now removes the buff with bFromUnEquip set, as live did (2014 captures:
RemoveBuff for buffs 3, 4, 5, 50 and 61 always carried bFromUnEquip,
and those are exactly the cancel_on_unequip buffs in the CDClient).

The client only drops a buff for such a removal when it was added with
cancelOnUnEquip (LWOBuffComponent::RemoveBuffIcon @ 0x00cf99b0), so
BuffComponent::RemoveBuff does the same to stay in step with it. Also
corrects the bFromRemoveBehavior comment: the client does not ignore the
message, it only removes buffs added with cancelOnRemoveBuff.

Replaces the TODO in InventoryComponent::RemoveBuff.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-09-28 22:31:04 -05:00

..

dBehaviors

fix(buffs): remove equipment buffs with bFromUnEquip on unequip

2026-09-28 22:31:04 -05:00

dComponents

fix(buffs): remove equipment buffs with bFromUnEquip on unequip

2026-09-28 22:31:04 -05:00

dEntity

chore: cleanup pointer management for LDF data (#1995)

2026-06-14 20:54:52 -07:00

dGameMessages

fix(buffs): remove equipment buffs with bFromUnEquip on unequip

2026-09-28 22:31:04 -05:00

dInventory

refactor: item set passive abilities come from the CDClient and item scripts

2026-09-28 22:30:58 -05:00

dMission

refactor: remaining game messages as structs, switch removed

2026-09-28 22:30:56 -05:00

dPropertyBehaviors

refactor: remaining game messages as structs, switch removed

2026-09-28 22:30:56 -05:00

dUtilities

feat(dashboard): check uploaded character XML before storing it

2026-09-28 22:30:59 -05:00

Character.cpp

fix: read character flags the way they are written again

2026-09-28 22:30:59 -05:00

Character.h

feat: refuse stale character saves with a save generation

2026-09-28 22:30:51 -05:00

CMakeLists.txt

feat: allow SQLite database backend (#1663)

2024-12-17 16:07:07 -08:00

Entity.cpp

fix(pets): tamed pandas and crabs leave their spawn groups

2026-09-28 22:31:01 -05:00

Entity.h

fix(pets): tamed pandas and crabs leave their spawn groups

2026-09-28 22:31:01 -05:00

EntityManager.cpp

chore: simplify metrics (#1987)

2026-06-08 21:42:32 -07:00

EntityManager.h

feat: hardcore limit % coins dropped on death (#1898)

2025-10-04 17:25:23 -07:00

LeaderboardManager.cpp

refactor: remaining game messages as structs, switch removed

2026-09-28 22:30:56 -05:00

LeaderboardManager.h

feat: web dashboard and playground work

2026-09-28 22:30:43 -05:00

PlayerManager.cpp

chore: Player class removal (#1445)

2024-02-04 06:29:05 -08:00

PlayerManager.h

chore: Player class removal (#1445)

2024-02-04 06:29:05 -08:00

TeamManager.cpp

feat: Loot rework (#1909)

2025-10-15 00:53:39 -05:00

TeamManager.h

feat: Loot rework (#1909)

2025-10-15 00:53:39 -05:00

TradingManager.cpp

refactor: vendor, donation and trade game messages as structs

2026-09-28 22:30:53 -05:00

TradingManager.h

chore: Remove pointer usage in trading (#1988)

2026-06-09 16:05:21 -05:00

User.cpp

refactor: chat packets as structs

2026-09-28 22:30:50 -05:00

User.h

feat: web dashboard and playground work

2026-09-28 22:30:43 -05:00

UserManager.cpp

refactor: chat packets as structs

2026-09-28 22:30:50 -05:00

UserManager.h

refactor: world packets as structs

2026-09-28 22:30:49 -05:00