mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2024-09-20 09:31:31 +00:00
a2ca273370
* Add failArmor server side Address out of bounds reading in behavior Address the basicAttackBehavior reading out of bounds memory and reading bits that didnt exist, which occasionally caused crashes and also caused the behavior to do undefined behavior due to the bad reads. Tested that attacking a wall anywhere with a projectile now does not crash the game. Tested with logs that the behavior correctly returned when there were no allocated bits or returned when other states were met. Add back logs and add fail handle Remove comment block Revert "Add back logs and add fail handle" This reverts commit db19be0906fc8bf35bf89037e2bfba39f5ef9c0c. Split out checks * Cleanup Behavior streams
51 lines
1.5 KiB
C++
51 lines
1.5 KiB
C++
#include "AirMovementBehavior.h"
|
|
#include "BehaviorBranchContext.h"
|
|
#include "BehaviorContext.h"
|
|
#include "EntityManager.h"
|
|
#include "Game.h"
|
|
#include "dLogger.h"
|
|
|
|
void AirMovementBehavior::Handle(BehaviorContext* context, RakNet::BitStream* bitStream, BehaviorBranchContext branch) {
|
|
uint32_t handle{};
|
|
|
|
if (!bitStream->Read(handle)) {
|
|
Game::logger->Log("AirMovementBehavior", "Unable to read handle from bitStream, aborting Handle! %i", bitStream->GetNumberOfUnreadBits());
|
|
return;
|
|
}
|
|
|
|
context->RegisterSyncBehavior(handle, this, branch);
|
|
}
|
|
|
|
void AirMovementBehavior::Calculate(BehaviorContext* context, RakNet::BitStream* bitStream, BehaviorBranchContext branch) {
|
|
const auto handle = context->GetUniqueSkillId();
|
|
|
|
bitStream->Write(handle);
|
|
}
|
|
|
|
void AirMovementBehavior::Sync(BehaviorContext* context, RakNet::BitStream* bitStream, BehaviorBranchContext branch) {
|
|
uint32_t behaviorId{};
|
|
|
|
if (!bitStream->Read(behaviorId)) {
|
|
Game::logger->Log("AirMovementBehavior", "Unable to read behaviorId from bitStream, aborting Sync! %i", bitStream->GetNumberOfUnreadBits());
|
|
return;
|
|
}
|
|
|
|
LWOOBJID target{};
|
|
|
|
if (!bitStream->Read(target)) {
|
|
Game::logger->Log("AirMovementBehavior", "Unable to read target from bitStream, aborting Sync! %i", bitStream->GetNumberOfUnreadBits());
|
|
return;
|
|
}
|
|
|
|
auto* behavior = CreateBehavior(behaviorId);
|
|
|
|
if (EntityManager::Instance()->GetEntity(target) != nullptr) {
|
|
branch.target = target;
|
|
}
|
|
|
|
behavior->Handle(context, bitStream, branch);
|
|
}
|
|
|
|
void AirMovementBehavior::Load() {
|
|
}
|