Files
DarkflameServer/dGame/TradingManager.h
Aaron Kimbrell c0b7a8f643 fix: check a trade offer against the items the player holds
A trade used the LOT and the count from the offer as the player sent
it. The offer is now resolved when it arrives and again when the trade
completes: the LOT comes from the held item, the count stops at the
held count, and an offer that names an unknown item, the same item
twice or a count of 0 is refused. The other player only receives an
item that was taken from the offering player.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 16:03:21 -06:00

96 lines
2.4 KiB
C++

#pragma once
#include "Entity.h"
#include <functional>
#include <map>
#include <memory>
#include <optional>
#include <vector>
struct TradeItem {
LWOOBJID itemId;
LOT itemLot;
uint32_t itemCount;
bool operator==(const TradeItem& other) const = default;
};
// What a player holds of an item they offered
struct HeldTradeItem {
LOT lot;
uint32_t count;
};
class Trade {
public:
/**
* Checks the items a player offered against the items they hold.
* @param offered the items as the player sent them
* @param findHeld gives the held item with an ID, or nothing if the player has no such item
* @return the offer with every LOT taken from the held item and every count limited to the held count,
* or nothing if the offer names an item the player does not hold, the same item twice or a count of 0
*/
static std::optional<std::vector<TradeItem>> ResolveOffer(
const std::vector<TradeItem>& offered,
const std::function<std::optional<HeldTradeItem>(LWOOBJID)>& findHeld);
explicit Trade(LWOOBJID tradeId, LWOOBJID participantA, LWOOBJID participantB);
~Trade();
LWOOBJID GetTradeId() const;
bool IsParticipant(LWOOBJID playerId) const;
LWOOBJID GetParticipantA() const;
LWOOBJID GetParticipantB() const;
Entity* GetParticipantAEntity() const;
Entity* GetParticipantBEntity() const;
void SetCoins(LWOOBJID participant, uint64_t coins);
void SetItems(LWOOBJID participant, std::vector<TradeItem> items);
void SetAccepted(LWOOBJID participant, bool value);
void Complete();
void Cancel(const LWOOBJID canceller);
void SendUpdateToOther(LWOOBJID participant);
private:
LWOOBJID m_TradeId = LWOOBJID_EMPTY;
LWOOBJID m_ParticipantA = LWOOBJID_EMPTY;
LWOOBJID m_ParticipantB = LWOOBJID_EMPTY;
uint64_t m_CoinsA = 0;
uint64_t m_CoinsB = 0;
std::vector<TradeItem> m_ItemsA{};
std::vector<TradeItem> m_ItemsB{};
bool m_AcceptedA = false;
bool m_AcceptedB = false;
};
class TradingManager {
public:
static TradingManager* Instance() {
if (!m_Address) {
m_Address = new TradingManager();
}
return m_Address;
}
const std::unique_ptr<Trade>& GetTrade(LWOOBJID tradeId) const;
const std::unique_ptr<Trade>& GetPlayerTrade(LWOOBJID playerId) const;
void CancelTrade(const LWOOBJID canceller, LWOOBJID tradeId, const bool sendCancelMessage = true);
void NewTrade(LWOOBJID participantA, LWOOBJID participantB);
private:
static TradingManager* m_Address; //For singleton method
std::unordered_map<LWOOBJID, std::unique_ptr<Trade>> trades;
};