mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2026-11-15 00:07:13 +00:00
02623be7fb
Every live save had <mnt a="..."/>, which LWOMountControlComponent::LoadFromSaveData (0x00bf99c0) reads as the character's mount item (0 on the 450 saves looked at). The server wrote no such element. MountControlComponent now writes it: the item of the mount being ridden, 0 on foot. The saved value is read and kept; nothing is mounted from it, as riding does not go on over a world change. A save from before gains <mnt a="0"/> and nothing else in it changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
63 lines
2.5 KiB
C++
63 lines
2.5 KiB
C++
// The mount item in a character's save: LWOMountControlComponent::LoadFromSaveData (0x00bf99c0) reads <mnt a>, and
|
|
// every live save had the element (<mnt a="0"/> on the 450 looked at).
|
|
#include "GameDependencies.h"
|
|
|
|
#include "Entity.h"
|
|
#include "MountControlComponent.h"
|
|
#include "PossessorComponent.h"
|
|
|
|
#include "tinyxml2.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <string>
|
|
|
|
class MountControlComponentTests : public GameDependenciesTest {
|
|
protected:
|
|
void SetUp() override { SetUpDependencies(); }
|
|
void TearDown() override { TearDownDependencies(); }
|
|
|
|
static std::string Print(const tinyxml2::XMLDocument& doc) {
|
|
tinyxml2::XMLPrinter printer(nullptr, true);
|
|
doc.Print(&printer);
|
|
return printer.CStr();
|
|
}
|
|
};
|
|
|
|
// A save from before the element was written gains it, and nothing else changes
|
|
TEST_F(MountControlComponentTests, OldSaveGainsTheElement) {
|
|
tinyxml2::XMLDocument doc;
|
|
ASSERT_EQ(doc.Parse(R"(<obj v="1"><mf hc="1"/><char cc="5"/><dest hm="4"/></obj>)"), tinyxml2::XML_SUCCESS);
|
|
Entity player(70, info);
|
|
auto* const mountControl = player.AddComponent<MountControlComponent>(-1);
|
|
mountControl->LoadFromSaveData(doc);
|
|
EXPECT_EQ(mountControl->GetSavedMountItemID(), LWOOBJID_EMPTY);
|
|
mountControl->WriteSaveData(doc);
|
|
EXPECT_EQ(Print(doc), R"(<obj v="1"><mf hc="1"/><char cc="5"/><dest hm="4"/><mnt a="0"/></obj>)");
|
|
// Saving again changes nothing
|
|
mountControl->WriteSaveData(doc);
|
|
EXPECT_EQ(Print(doc), R"(<obj v="1"><mf hc="1"/><char cc="5"/><dest hm="4"/><mnt a="0"/></obj>)");
|
|
}
|
|
|
|
// The item of the mount being ridden is saved, in the element's own place; on foot it is 0 again
|
|
TEST_F(MountControlComponentTests, TheRiddenMountIsSaved) {
|
|
tinyxml2::XMLDocument doc;
|
|
ASSERT_EQ(doc.Parse(R"(<obj v="1"><mis/><mnt a="1152921510436607007"/><dest hm="4"/></obj>)"), tinyxml2::XML_SUCCESS);
|
|
Entity player(71, info);
|
|
auto* const possessor = player.AddComponent<PossessorComponent>(-1);
|
|
auto* const mountControl = player.AddComponent<MountControlComponent>(-1);
|
|
mountControl->LoadFromSaveData(doc);
|
|
EXPECT_EQ(mountControl->GetSavedMountItemID(), 1152921510436607007LL);
|
|
|
|
// Nothing is ridden after a load
|
|
mountControl->WriteSaveData(doc);
|
|
EXPECT_EQ(Print(doc), R"(<obj v="1"><mis/><mnt a="0"/><dest hm="4"/></obj>)");
|
|
|
|
possessor->SetMountItemID(1152921510436607123LL);
|
|
mountControl->WriteSaveData(doc);
|
|
EXPECT_EQ(Print(doc), R"(<obj v="1"><mis/><mnt a="1152921510436607123"/><dest hm="4"/></obj>)");
|
|
|
|
possessor->SetMountItemID(LWOOBJID_EMPTY);
|
|
mountControl->WriteSaveData(doc);
|
|
EXPECT_EQ(Print(doc), R"(<obj v="1"><mis/><mnt a="0"/><dest hm="4"/></obj>)");
|
|
}
|