address some feedback

This commit is contained in:
Aaron Kimbre 2023-11-13 21:04:40 -06:00
parent a6a6353dfc
commit e969918dd1
3 changed files with 6 additions and 7 deletions

View File

@ -24,7 +24,6 @@ void SortTable(LootTableEntries& table) {
lootToInsert = oldItrInner;
}
}
std::swap(*oldItrOuter, *lootToInsert);
}
}

View File

@ -113,9 +113,9 @@ std::vector<uint32_t> PropertyEntranceComponent::GetPropertyIDsBasedOnParams(con
propertyLookup->setString(4, searchString.c_str());
propertyLookup->setInt(5, sortMethod == SORT_TYPE_FEATURED || sortMethod == SORT_TYPE_FRIENDS ? (uint32_t)PropertyPrivacyOption::Friends : (uint32_t)PropertyPrivacyOption::Public);
auto propertyIdRes = propertyLookup->executeQuery();
auto* propertyIdRes = propertyLookup->executeQuery();
std::vector<uint32_t> propertyIds{};
std::vector<uint32_t> propertyIds;
while (propertyIdRes->next()) {
if (sortMethod == SORT_TYPE_FRIENDS || sortMethod == SORT_TYPE_FEATURED) {
@ -164,7 +164,7 @@ void PropertyEntranceComponent::OnPropertyEntranceSync(Entity* entity, bool incl
std::vector<uint32_t> propertyIdsSlice(propertyIds.begin() + startIndex, propertyIds.begin() + std::min(startIndex + numResults, (int32_t)propertyIds.size()));
std::vector<uint32_t> propertyCloneIdSlice{};
std::vector<uint32_t> propertyCloneIdSlice;
for (const auto& id : propertyIdsSlice) {
auto prop = this->GetPropertyData(id);

View File

@ -3105,19 +3105,19 @@ void GameMessages::SendPropertySelectQuery(LWOOBJID objectId, int32_t navOffset,
const auto& owner = GeneralUtils::UTF8ToUTF16(item.PrimaryData.OwnerName);
bitStream.Write(uint32_t(owner.size()));
for (uint32_t i = 0; i < owner.size(); ++i) {
bitStream.Write(static_cast<uint16_t>(owner[i]));
bitStream.Write(owner[i]);
}
const auto& name = GeneralUtils::UTF8ToUTF16(item.PrimaryData.Name);
bitStream.Write(uint32_t(name.size()));
for (uint32_t i = 0; i < name.size(); ++i) {
bitStream.Write(static_cast<uint16_t>(name[i]));
bitStream.Write(name[i]);
}
const auto& description = GeneralUtils::UTF8ToUTF16(item.PrimaryData.Description);
bitStream.Write(uint32_t(description.size()));
for (uint32_t i = 0; i < description.size(); ++i) {
bitStream.Write(static_cast<uint16_t>(description[i]));
bitStream.Write(description[i]);
}
bitStream.Write(item.PrimaryData.Reputation);