refactor: mission, flag and collectible game messages as structs

Converts OfferMission, NotifyMission, NotifyMissionTask, ResetMissions,
NotifyClientFlagChange and NotifyLevelRewards (sent with SendToClient:
the old functions never broadcast) and the received RespondToMission,
MissionDialogueOK, RequestLinkedMission, SetFlag and HasBeenCollected
to NetGameMsgs in MissionMessages.{h,cpp}. Callers are switched,
OfferMission's send-it-twice behaviour moves to MissionOfferComponent,
the received messages are registered in GameMessageHandler's map and
the old functions are deleted. Handlers are copied verbatim. The
byte-equality helper can now compare SendToClient messages.

No wire change and no change in recipients. Verified byte for byte
against a frozen verbatim copy of the old functions over an input grid
(including OfferMission's two packets), received messages compared with
the old handlers' read sequences and every truncated payload rejected,
hand computed golden bytes and round trips. Layouts confirmed against
the 1.10.64 client in Ghidra.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-26 12:44:51 -05:00
parent 2681cc51ff
commit d599b788d0
16 changed files with 904 additions and 275 deletions

View File

@@ -1,4 +1,5 @@
#include "LevelProgressionComponent.h"
#include "MissionMessages.h"
#include "ControllablePhysicsComponent.h"
#include "InventoryComponent.h"
#include "CharacterComponent.h"
@@ -53,8 +54,13 @@ void LevelProgressionComponent::HandleLevelUp() {
auto* controllablePhysicsComponent = m_Parent->GetComponent<ControllablePhysicsComponent>();
if (!inventoryComponent || !controllablePhysicsComponent) return;
GameMessages::NotifyLevelRewards levelRewards;
levelRewards.target = m_Parent->GetObjectID();
levelRewards.level = m_Level;
// Tell the client we beginning to send level rewards.
if (rewardingItem) GameMessages::NotifyLevelRewards(m_Parent->GetObjectID(), m_Parent->GetSystemAddress(), m_Level, rewardingItem);
levelRewards.sendingRewards = rewardingItem;
if (rewardingItem) levelRewards.SendToClient(m_Parent->GetSystemAddress());
for (const auto& reward : rewards) {
switch (reward.rewardType) {
@@ -79,7 +85,8 @@ void LevelProgressionComponent::HandleLevelUp() {
}
}
// Tell the client we have finished sending level rewards.
if (rewardingItem) GameMessages::NotifyLevelRewards(m_Parent->GetObjectID(), m_Parent->GetSystemAddress(), m_Level, !rewardingItem);
levelRewards.sendingRewards = !rewardingItem;
if (rewardingItem) levelRewards.SendToClient(m_Parent->GetSystemAddress());
}
void LevelProgressionComponent::SetRetroactiveBaseSpeed(){