Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2026-11-15 08:17:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(inventory): the charxml's items element has nn="1", as live

Browse Source 
Live charxmls carried <items nn="1"> (225 of 226 captured).
LWOInventoryComponent_Common::LoadFromSaveData (0x00d1ec40) reads it and
then does not add the inventory component's template items to the loaded
character. No effect on players today (the player LOT's inventory
component has no items); the server never wrote it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-10-02 10:33:30 -05:00
parent df3f46b43b
commit a538f32382
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dGame/dComponents/InventoryComponent.cpp
View File

@@ -860,6 +860,9 @@ void InventoryComponent::WriteSaveData(tinyxml2::XMLDocument& document) {
}
items->DeleteChildren();
// As live wrote it (225 of 226 captured charxmls): LWOInventoryComponent_Common::LoadFromSaveData (0x00d1ec40) then
// doesn't add the inventory component's template items to a loaded character
items->SetAttribute("nn", 1);
// Saved while the equipped items are pushed (build mode, possibly carrying a model): the character's equipment is
// the pushed state, which PopEquippedItems puts back, not the temporary items equipped since.

6
tests/dGameTests/dComponentsTests/InventorySaveTests.cpp
View File

@@ -93,3 +93,9 @@ TEST_F(InventorySaveTests, ItemTakenOffInBuildModeIsStillSavedEquipped) {
EXPECT_TRUE(SavedEquipped(hat->GetId()));
}
// Live charxmls have <items nn="1">
TEST_F(InventorySaveTests, ItemsAreSavedWithNn) {
inventory->WriteSaveData(doc);
EXPECT_STREQ(doc.FirstChildElement("obj")->FirstChildElement("inv")->FirstChildElement("items")->Attribute("nn"), "1");
}