Move to new branch

Added comments

Added some comments and changed a variable name to be less ambiguous.
This commit is contained in:
EmosewaMC 2022-06-19 00:14:33 -07:00
parent ba5037300f
commit 9cf534dc0a
3 changed files with 41 additions and 35 deletions

View File

@ -99,22 +99,6 @@ Entity::~Entity() {
m_Character->SaveXMLToDatabase();
}
if (IsPlayer()) {
Entity* zoneControl = EntityManager::Instance()->GetZoneControlEntity();
for (CppScripts::Script* script : CppScripts::GetEntityScripts(zoneControl)) {
script->OnPlayerExit(zoneControl, this);
}
std::vector<Entity*> scriptedActs = EntityManager::Instance()->GetEntitiesByComponent(COMPONENT_TYPE_SCRIPTED_ACTIVITY);
for (Entity* scriptEntity : scriptedActs) {
if (scriptEntity->GetObjectID() != zoneControl->GetObjectID()) { // Don't want to trigger twice on instance worlds
for (CppScripts::Script* script : CppScripts::GetEntityScripts(scriptEntity)) {
script->OnPlayerExit(scriptEntity, this);
}
}
}
}
CancelAllTimers();
CancelCallbackTimers();

View File

@ -217,39 +217,44 @@ void EntityManager::UpdateEntities(const float deltaTime) {
m_EntitiesToKill.clear();
for (const auto& entry : m_EntitiesToDelete)
for (const auto entry : m_EntitiesToDelete)
{
auto* entity = GetEntity(entry);
// Get all this info first before we delete the player.
auto entityToDelete = GetEntity(entry);
m_Entities.erase(entry);
auto networkIdToErase = entityToDelete->GetNetworkId();
const auto& iter = std::find(m_EntitiesToGhost.begin(), m_EntitiesToGhost.end(), entity);
const auto& ghostingToDelete = std::find(m_EntitiesToGhost.begin(), m_EntitiesToGhost.end(), entityToDelete);
if (iter != m_EntitiesToGhost.end())
if (entityToDelete != nullptr)
{
m_EntitiesToGhost.erase(iter);
}
if (entity != nullptr)
// If we are a player run through the player destructor.
if (entityToDelete->IsPlayer())
{
if (entity->GetNetworkId() != 0)
{
m_LostNetworkIds.push(entity->GetNetworkId());
}
if (entity->IsPlayer())
{
delete dynamic_cast<Player*>(entity);
delete dynamic_cast<Player*>(entityToDelete);
}
else
{
delete entity;
delete entityToDelete;
}
entity = nullptr;
entityToDelete = nullptr;
if (networkIdToErase != 0)
{
m_LostNetworkIds.push(networkIdToErase);
}
}
if (ghostingToDelete != m_EntitiesToGhost.end())
{
m_EntitiesToGhost.erase(ghostingToDelete);
}
m_Entities.erase(entry);
}
m_EntitiesToDelete.clear();
}

View File

@ -13,6 +13,7 @@
#include "dZoneManager.h"
#include "CharacterComponent.h"
#include "Mail.h"
#include "CppScripts.h"
std::vector<Player*> Player::m_Players = {};
@ -329,5 +330,21 @@ Player::~Player()
return;
}
if (IsPlayer()) {
Entity* zoneControl = EntityManager::Instance()->GetZoneControlEntity();
for (CppScripts::Script* script : CppScripts::GetEntityScripts(zoneControl)) {
script->OnPlayerExit(zoneControl, this);
}
std::vector<Entity*> scriptedActs = EntityManager::Instance()->GetEntitiesByComponent(COMPONENT_TYPE_SCRIPTED_ACTIVITY);
for (Entity* scriptEntity : scriptedActs) {
if (scriptEntity->GetObjectID() != zoneControl->GetObjectID()) { // Don't want to trigger twice on instance worlds
for (CppScripts::Script* script : CppScripts::GetEntityScripts(scriptEntity)) {
script->OnPlayerExit(scriptEntity, this);
}
}
}
}
m_Players.erase(iter);
}