Merge pull request #490 from EmosewaMC/macos_compilation_warnings

Resolved MacOS (and possibly ARM?) compilation warnings
This commit is contained in:
David Markowitz 2022-04-07 12:09:37 -07:00 committed by GitHub
commit 92d36496df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 15 additions and 15 deletions

View File

@ -60,7 +60,7 @@ void Trade::SetCoins(LWOOBJID participant, uint64_t coins)
{
m_CoinsA = coins;
}
else if (participant = m_ParticipantB)
else if (participant == m_ParticipantB)
{
m_CoinsB = coins;
}
@ -72,7 +72,7 @@ void Trade::SetItems(LWOOBJID participant, std::vector<TradeItem> items)
{
m_ItemsA = items;
}
else if (participant = m_ParticipantB)
else if (participant == m_ParticipantB)
{
m_ItemsB = items;
}

View File

@ -51,7 +51,7 @@ public:
void LoadFromXML(tinyxml2::XMLDocument* doc);
void UpdateXml(tinyxml2::XMLDocument* doc);
void UpdateXml(tinyxml2::XMLDocument* doc) override;
void Serialize(RakNet::BitStream* outBitStream, bool bIsInitialUpdate, unsigned int& flags);

View File

@ -23,7 +23,7 @@ public:
ControllablePhysicsComponent(Entity* entity);
~ControllablePhysicsComponent() override;
void Update(float deltaTime);
void Update(float deltaTime) override;
void Serialize(RakNet::BitStream* outBitStream, bool bIsInitialUpdate, unsigned int& flags);
void LoadFromXML(tinyxml2::XMLDocument* doc);
void ResetFlags();

View File

@ -29,8 +29,8 @@ public:
explicit MissionComponent(Entity* parent);
~MissionComponent() override;
void Serialize(RakNet::BitStream* outBitStream, bool bIsInitialUpdate, unsigned int& flags);
void LoadFromXml(tinyxml2::XMLDocument* doc);
void UpdateXml(tinyxml2::XMLDocument* doc);
void LoadFromXml(tinyxml2::XMLDocument* doc) override;
void UpdateXml(tinyxml2::XMLDocument* doc) override;
/**
* Returns all the missions for this entity, mapped by mission ID

View File

@ -17,7 +17,7 @@ public:
~ModuleAssemblyComponent() override;
void Serialize(RakNet::BitStream* outBitStream, bool bIsInitialUpdate, unsigned int& flags);
void Update(float deltaTime);
void Update(float deltaTime) override;
/**
* Sets the subkey of this entity

View File

@ -61,7 +61,7 @@ public:
MovementAIComponent(Entity* parentEntity, MovementAIInfo info);
~MovementAIComponent() override;
void Update(float deltaTime);
void Update(float deltaTime) override;
/**
* Returns the basic settings that this entity uses to move around

View File

@ -19,7 +19,7 @@ public:
void Serialize(RakNet::BitStream* outBitStream, bool bIsInitialUpdate, unsigned int& flags);
void OnUse(Entity* originator);
void OnUse(Entity* originator) override;
/**
* Gets the buy scaler

View File

@ -7,7 +7,7 @@ public:
void OnStartup(Entity* self) override;
void OnUse(Entity* self, Entity* user) override;
void OnTimerDone(Entity* self, std::string timerName) override;
void OnNotifyObject(Entity *self, Entity *sender, const std::string& name, int32_t param1 = 0, int32_t param2 = 0);
void OnNotifyObject(Entity *self, Entity *sender, const std::string& name, int32_t param1 = 0, int32_t param2 = 0) override;
void MoveBridgeDown(Entity* self, Entity* bridge, bool down);
void NotifyDie(Entity* self, Entity* other);

View File

@ -25,7 +25,7 @@ void BaseConsoleTeleportServer::BaseOnMessageBoxResponse(Entity* self, Entity* s
if (rocketLaunchComponent == nullptr)
{
rocketLaunchComponent;
return;
}
const auto& teleportZone = self->GetVar<std::u16string>(u"transferZoneID");

View File

@ -4,11 +4,11 @@
class GfCampfire : public CppScripts::Script
{
public:
void OnStartup(Entity* self);
void OnStartup(Entity* self) override;
void OnFireEventServerSide(Entity *self, Entity *sender, std::string args, int32_t param1, int32_t param2,
int32_t param3);
void OnProximityUpdate(Entity* self, Entity* entering, std::string name, std::string status);
void OnTimerDone(Entity* self, std::string timerName);
int32_t param3) override;
void OnProximityUpdate(Entity* self, Entity* entering, std::string name, std::string status) override;
void OnTimerDone(Entity* self, std::string timerName) override;
void OnSkillEventFired(Entity *self, Entity *caster, const std::string &message) override;
private:
int32_t m_skillCastId = 43;