Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2026-11-14 07:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(inventory): an inventory group holds at most 1000 LOTs, as the client

Browse Source 
LWOInventoryComponent_Common::msgUpdateInventoryGroupContents (0x00ce1f50)
ignores an ADD to an unlocked group that already holds 1000 LOTs. The
server had no cap, so a modified client could grow the charxml without
limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-10-02 10:31:02 -05:00
parent 042594e3dd
commit 841004e6a4
3 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dGame/dComponents/InventoryComponent.cpp
View File

@@ -2021,6 +2021,8 @@ void InventoryComponent::UpdateGroup(const GroupUpdate& groupUpdate) {
break;
}
case GroupUpdateCommand::ADD_LOT: {
// msgUpdateInventoryGroupContents (0x00ce1f50): a group holds at most 1000 LOTs
if (groupItr->lots.size() >= MaximumGroupLotCount) break;
groupItr->lots.insert(groupUpdate.lot);
break;
}

1
dGame/dComponents/InventoryComponent.h
View File

@@ -101,6 +101,7 @@ public:
static constexpr uint32_t MaximumGroupCount = 50;
static constexpr size_t MaximumGroupNameLength = 64; // UTF-16 characters
static constexpr size_t MaximumGroupLotCount = 1000;
static constexpr eReplicaComponentType ComponentType = eReplicaComponentType::INVENTORY;

8
tests/dGameTests/dComponentsTests/InventoryGroupTests.cpp
View File

@@ -88,3 +88,11 @@ TEST_F(InventoryGroupTests, ClearEmptiesAGroup) {
ASSERT_EQ(Groups().size(), 1u);
EXPECT_TRUE(Groups()[0].lots.empty());
}
TEST_F(InventoryGroupTests, AGroupHoldsAtMost1000Lots) {
Group("ADD", "user_group1", u"bricks");
for (LOT lot = 1; lot <= 1001; lot++) Contents("ADD", "user_group1", lot);
EXPECT_EQ(Groups()[0].lots.size(), 1000u);
EXPECT_FALSE(Groups()[0].lots.contains(1001));
}