Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2026-10-02 02:43:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(messages): DownloadPropertyData against a live capture packet

Browse Source 
Adds FromLiveCapture, which reads a whole captured game message packet
into a struct and requires the struct to write the same bytes back, and
checks DownloadPropertyData (716) with an unowned property packet from
the 2011/2012 live captures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-28 23:40:13 -05:00
parent a52e777097
commit 7d28405559
2 changed files with 44 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/dGameTests/dGameMessagesTests/GameMessageTestUtils.h
View File

@@ -79,6 +79,24 @@ namespace GameMessageTestUtils {
return copy;
}
// Reads a whole game message packet copied from a live capture (hex), requires its header to carry T's message ID
// and the payload to be consumed up to the byte padding, and requires the struct to write the same bytes back.
template<typename T>
T FromLiveCapture(const std::string& hex) {
auto live = FromHex(hex);
RakNet::BitStream bitStream(live.bytes.data(), live.bytes.size(), false);
T msg;
LWOOBJID target{};
MessageType::Game msgId{};
EXPECT_TRUE(GameMessages::NetGameMsg::ReadPacketHeader(bitStream, target, msgId));
EXPECT_EQ(msgId, msg.msgId);
EXPECT_TRUE(msg.Deserialize(bitStream));
EXPECT_LT(bitStream.GetNumberOfUnreadBits(), 8u);
msg.target = target;
EXPECT_EQ(StructPacket(msg).bytes, live.bytes);
return msg;
}
// Checks that every strict prefix of msg's serialized payload fails to deserialize.
template<typename T>
void ExpectTruncatedFails(const T& msg) {

26
tests/dGameTests/dGameMessagesTests/PropertyMessagesTests.cpp
View File

@@ -221,6 +221,32 @@ TEST_F(PropertyMessagesTests, DownloadPropertyDataMatchesLegacy) {
}
}
// A packet from a 2011/2012 live capture: DownloadPropertyData (716) for an unclaimed Nimbus Station medium
// property (no owner, so no player data). Every complete 716 packet in the captures decodes with this layout.
TEST_F(PropertyMessagesTests, DownloadPropertyDataMatchesLiveCapture) {
const auto msg = FromLiveCapture<GameMessages::DownloadPropertyData>(
"5305000c000000009847000000400004cc02000000000000000065620000e304b004000000000000000000000000000000000000"
"0000000000000000000000000000e8030000010000000000000000000000e803000000000000000000000d0000004e0053004d00"
"65006400500072006f007000650072007400790000000000000000000600000000000000010000000000000000000000000000"
"000000000000000000000000000000000000000000000080b4c3000090430000e0420000004300000000000000000004000000"
"cdcc8a42cd8ce343cd4c1f4300008ac2cd8ce343cd4c1f4300008ac2cd8ce343cdcc0242cdcc8a42cd8ce343cdcc0242");
EXPECT_EQ(msg.target, 0x0400400000004798LL);
EXPECT_EQ(msg.propertyId, LWOOBJID_EMPTY);
EXPECT_EQ(msg.templateId, 25189);
EXPECT_EQ(msg.mapId, 1251);
EXPECT_EQ(msg.vendorMapId, 1200);
EXPECT_EQ(msg.ownerId, LWOOBJID_EMPTY);
EXPECT_EQ(msg.rent, 1000u);
EXPECT_EQ(msg.rentalPeriod, 1u);
EXPECT_EQ(msg.rentAmount, 1000u);
EXPECT_EQ(msg.spawnName, u"NSMedProperty");
EXPECT_EQ(msg.rentDuration, 6u);
EXPECT_EQ(msg.durationType, 1u);
EXPECT_EQ(msg.zonePosition, NiPoint3(-361.0f, 288.0f, 112.0f));
EXPECT_EQ(msg.maxBuildHeight, 128.0f);
EXPECT_EQ(msg.pathPositions.size(), 4u);
}
TEST_F(PropertyMessagesTests, PropertyRentalResponseMatchesLegacy) {
for (const auto target : g_Targets) {
for (const auto value : g_Ints) {