fix: optional party phrases (#1377)

* fix: optional party phrases

Don't return early if there are no party phrases

* Update VanityUtilities.cpp
This commit is contained in:
Daniel Seiler 2024-01-02 00:08:38 +01:00 committed by GitHub
parent e54faa3820
commit 18feea5fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -294,21 +294,20 @@ void VanityUtilities::ParseXML(const std::string& file) {
auto* partyPhrases = npcs->FirstChildElement("partyphrases");
if (partyPhrases == nullptr) {
LOG("Failed to parse party phrases");
return;
}
LOG("No party phrases found");
} else {
for (auto* phrase = partyPhrases->FirstChildElement("phrase"); phrase != nullptr;
phrase = phrase->NextSiblingElement("phrase")) {
// Get the phrase
auto* text = phrase->GetText();
for (auto* phrase = partyPhrases->FirstChildElement("phrase"); phrase != nullptr;
phrase = phrase->NextSiblingElement("phrase")) {
// Get the phrase
auto* text = phrase->GetText();
if (text == nullptr) {
LOG("Failed to parse party phrase");
continue;
}
if (text == nullptr) {
LOG("Failed to parse party phrase");
continue;
m_PartyPhrases.push_back(text);
}
m_PartyPhrases.push_back(text);
}
for (auto* npc = npcs->FirstChildElement("npc"); npc != nullptr; npc = npc->NextSiblingElement("npc")) {