Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2024-11-24 22:47:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: optional party phrases (#1377)

Browse Source 
* fix: optional party phrases

Don't return early if there are no party phrases

* Update VanityUtilities.cpp
This commit is contained in:
Daniel Seiler 2024-01-02 00:08:38 +01:00 committed by GitHub
parent e54faa3820
commit 18feea5fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
dGame/dUtilities/VanityUtilities.cpp
View File

@ -294,21 +294,20 @@ void VanityUtilities::ParseXML(const std::string& file) {
auto* partyPhrases = npcs->FirstChildElement("partyphrases"); auto* partyPhrases = npcs->FirstChildElement("partyphrases");
if (partyPhrases == nullptr) { if (partyPhrases == nullptr) {
LOG("Failed to parse party phrases"); LOG("No party phrases found");
return; } else {
} for (auto* phrase = partyPhrases->FirstChildElement("phrase"); phrase != nullptr;
phrase = phrase->NextSiblingElement("phrase")) {
for (auto* phrase = partyPhrases->FirstChildElement("phrase"); phrase != nullptr; // Get the phrase
phrase = phrase->NextSiblingElement("phrase")) { auto* text = phrase->GetText();
// Get the phrase
auto* text = phrase->GetText(); if (text == nullptr) {
LOG("Failed to parse party phrase");
if (text == nullptr) { continue;
LOG("Failed to parse party phrase"); }
continue;
m_PartyPhrases.push_back(text);
} }
m_PartyPhrases.push_back(text);
} }
for (auto* npc = npcs->FirstChildElement("npc"); npc != nullptr; npc = npc->NextSiblingElement("npc")) { for (auto* npc = npcs->FirstChildElement("npc"); npc != nullptr; npc = npc->NextSiblingElement("npc")) {