Mirrored_Repos/yattee
1
0
Fork 0
mirror of https://github.com/yattee/yattee.git synced 2026-07-19 22:02:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing storyboards when advancing to next queued video

Browse Source 
Queue items carry a pre-resolved stream, so play() takes the
provided-stream shortcut and skips the full API fetch that populates
storyboards. The follow-up loadOnlineStreams() call fetched the response
containing them but dropped storyboards on the floor.

Keep the storyboards in loadOnlineStreams() and apply them when none are
set (preserving local storyboards for downloaded playback), and bail out
if the current video changed during the fetch.
This commit is contained in:
Arkadiusz Fal
2026-06-18 23:49:15 +02:00
parent e42e48fcee
commit 5bc774dd83
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Yattee/Services/Player/PlayerService.swift
View File

@@ -1287,12 +1287,25 @@ final class PlayerService {
defer { isLoadingOnlineStreams = false }
do {
let (_, streams, captions) = try await fetchVideoStreamsAndCaptions(for: video)
let (_, streams, captions, storyboards) = try await fetchVideoStreamsAndCaptionsAndStoryboards(for: video)
// Bail if the user moved on to another video while we were fetching
guard state.currentVideo?.id == video.id else { return }
// Combine downloaded streams with online streams (downloaded first)
let combined = downloadedStreams + streams
availableStreams = combined
availableCaptions = captions
// Queue items carry a pre-resolved stream, so play() skipped the
// full fetch that populates storyboards — fill them in here.
// Don't clobber a local storyboard loaded for downloaded playback.
if state.storyboards.isEmpty, !storyboards.isEmpty {
Task { await StoryboardService.shared.clearCache() }
state.storyboards = storyboards
LoggingService.shared.logPlayer("Loaded \(storyboards.count) storyboards (deferred), preferred: \(state.preferredStoryboard?.width ?? 0)x\(state.preferredStoryboard?.height ?? 0)")
}
// The freshly fetched streams have new (signed) URLs that won't
// match `state.currentStream`/`state.currentAudioStream` from the
// queue's pre-resolved entry — repoint state to the equivalent