mirror of
https://github.com/python-kasa/python-kasa.git
synced 2026-10-26 14:42:56 +00:00
30f5e4a1b9
Some legacy iot firmware stops responding when an unsupported module follows `system` in a request, which made every update time out once the HomeKit query was added. This stops querying HomeKit in `update()` for IOT devices and adds `Device.supports_module()` API to allow checking if some module is supported by the device.
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
from unittest.mock import PropertyMock, patch
|
|
|
|
import pytest
|
|
|
|
from kasa import Module
|
|
from kasa.iot import IotDevice
|
|
from kasa.iot.modules.homekit import HomeKit
|
|
|
|
from ...device_fixtures import device_iot
|
|
|
|
HOMEKIT = "smartlife.iot.homekit"
|
|
|
|
|
|
async def _homekit_module(dev: IotDevice) -> HomeKit:
|
|
"""Create the module with the data from the device, skip if not supported."""
|
|
if not await dev.supports_module(Module.IotHomeKit):
|
|
pytest.skip("HomeKit module not present on this device")
|
|
homekit = HomeKit(dev, HOMEKIT)
|
|
dev._last_update.update(await dev.protocol.query(homekit.query()))
|
|
homekit._initialize_features()
|
|
return homekit
|
|
|
|
|
|
@device_iot
|
|
async def test_homekit_getters(dev: IotDevice) -> None:
|
|
# HomeKit can be present on any IOT device
|
|
homekit = await _homekit_module(dev)
|
|
info = homekit.info
|
|
if not info:
|
|
pytest.skip("No HomeKit data present for this fixture")
|
|
assert "setup_code" in info
|
|
assert "setup_payload" in info
|
|
assert "err_code" in info
|
|
# Check that the setup_code and setup_payload are strings
|
|
assert isinstance(info["setup_code"], str)
|
|
assert isinstance(info["setup_payload"], str)
|
|
assert isinstance(info["err_code"], int)
|
|
# Check that the HomeKit module properties match
|
|
assert info["setup_code"] == homekit.setup_code
|
|
assert info["setup_payload"] == homekit.setup_payload
|
|
|
|
|
|
@device_iot
|
|
async def test_homekit_feature(dev: IotDevice) -> None:
|
|
homekit = await _homekit_module(dev)
|
|
if not homekit.info:
|
|
pytest.skip("No HomeKit data present for this device")
|
|
feature = homekit._all_features.get("homekit_setup_code")
|
|
assert feature is not None
|
|
assert isinstance(feature.attribute_getter, str)
|
|
value = getattr(homekit, feature.attribute_getter)
|
|
assert value == homekit.setup_code
|
|
|
|
|
|
@device_iot
|
|
def test_initialize_features_skips_when_no_data(dev: IotDevice) -> None:
|
|
homekit = HomeKit(dev, HOMEKIT)
|
|
if "homekit_setup_code" in homekit._all_features:
|
|
pytest.skip("HomeKit feature already present on this device")
|
|
# Patch .data so it looks like no homekit data is present
|
|
with patch.object(HomeKit, "data", new_callable=PropertyMock) as mock_data:
|
|
mock_data.return_value = {}
|
|
homekit._initialize_features()
|
|
# Since there was no data, no features should be added
|
|
assert "homekit_setup_code" not in homekit._all_features
|
|
assert homekit.info == {}
|