Commit Graph

2195 Commits

Author SHA1 Message Date
Samantaz Fox
519c227c4f
Use short syntax for 'File.open' block 2022-01-29 13:43:26 +01:00
Samantaz Fox
6f4665588f
search.cr: use do/end rather than inline {} block 2022-01-28 15:54:38 +01:00
Samantaz Fox
63e1165936
videos.cr: use '.dig?()' where possible 2022-01-28 02:22:48 +01:00
Samantaz Fox
84cc732281
search functions: Don't return result count
This is useless, as the items count can be directly acessed
using the '.size' method, so use that instead when needed.
2022-01-28 02:22:36 +01:00
Samantaz Fox
971b6ec96f
Fix 'Lint/UselessAssign' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox
46f7ca9ffa
Remove useless intermediary variable in youtube_api.cr
This fixes an ameba warning
2022-01-28 02:19:53 +01:00
Samantaz Fox
dee20f92a7
Avoid infinite loop in ChannelVideo's to_xml/to_json methods 2022-01-28 02:19:53 +01:00
Samantaz Fox
12b818a83c
Fix more 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox
1c91110464
Fix some 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox
4cd7a3e83f
Remove useless 'locale = env.get...' from many routes 2022-01-28 02:19:53 +01:00
Samantaz Fox
fa99c9aa85
Use '.dig?()' in playlist parsing 2022-01-28 02:19:53 +01:00
Samantaz Fox
2d949834e9
Make 'additional_fields' optional in JSON error template functions
This allows us to de-duplicate functions
2022-01-28 02:19:53 +01:00
Samantaz Fox
c7b74aa8b4
Remove useless 'locale' argument from error template functions 2022-01-28 02:19:53 +01:00
Samantaz Fox
5e3c9cf290
Remove useless arguments from playlist-related functions 2022-01-28 02:19:53 +01:00
Samantaz Fox
2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search
Handle invalid channel id in channel: search
2022-01-25 19:34:43 +01:00
Matthew McGarvey
c5967ad572
will -> should
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2022-01-25 11:35:19 -06:00
matthewmcgarvey
574e35a720 HTML escape user input 2022-01-19 09:01:13 -06:00
Samantaz Fox
32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments
Fix loading reddit comments when there are no threads found
2022-01-19 12:53:20 +01:00
matthewmcgarvey
56e505164d 404 error with message and provide example 2022-01-18 18:56:26 -06:00
matthewmcgarvey
d4f3139b73 Don't catch and provide better error message instead 2022-01-18 18:37:16 -06:00
matthewmcgarvey
97dceb3a5a Custom error on channel search, handle in search 2022-01-18 18:37:16 -06:00
matthewmcgarvey
212f6d6bf5 Fix channel search json parse to not raise 2022-01-18 18:37:16 -06:00
Samantaz Fox
8c2495a399
Apply suggestions from review 2022-01-17 21:47:29 +01:00
matthewmcgarvey
9233f71549 Use &.methods where possible instead of curly braces 2022-01-17 13:03:36 -06:00
matthewmcgarvey
b2a738cf13 Fix loading reddit comments when there are no threads found 2022-01-17 12:11:47 -06:00
Samantaz Fox
34a79c5f1e
Don't show "next steps" message with a stack trace
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
2022-01-16 16:15:23 +01:00
Samantaz Fox
a2600acfa9
Improve crash page messages
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
2022-01-16 16:15:23 +01:00
Samantaz Fox
250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus
Fix search autofocus
2022-01-16 15:24:27 +01:00
Samantaz Fox
6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import
Add CSV Subscriptions Import
2022-01-16 15:11:37 +01:00
Samantaz Fox
6cf6c56dd1
Autofocus search bar only on search homepage 2022-01-13 22:19:19 +01:00
Samantaz Fox
8b72481b8c
Fix comments
"ReplyCount" is actually an Int, not a String.
2022-01-13 20:43:46 +01:00
Samantaz Fox
aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales
Better support of plurals in locales
2022-01-13 12:55:55 +01:00
Samantaz Fox
eff8b23f57
Improve youtube import type detection
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
2022-01-12 18:13:15 +01:00
Samantaz Fox
81a2300af8
Prevent import of insanely large files 2022-01-12 01:28:58 +01:00
Samantaz Fox
fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels
Update to fetch related channels again
2022-01-11 01:50:48 +01:00
matthewmcgarvey
dc62b6ffdb Can fetch related channels using just the channel ucid] 2022-01-10 17:07:52 -06:00
Samantaz Fox
eb7e79fdf7
i18n: Apply code review suggestions + code cleaning 2022-01-10 22:49:07 +01:00
Samantaz Fox
37c953e633
i18n: Use plurals for tokens/replies/unseen notifications 2022-01-10 22:49:07 +01:00
Samantaz Fox
5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts 2022-01-10 22:49:07 +01:00
Samantaz Fox
692f4e5be2
i18n: Use plurals for year/month/day/etc... 2022-01-10 22:49:07 +01:00
Samantaz Fox
7bb1471207
i18n: Add dedicated function for counts translation 2022-01-10 22:49:07 +01:00
Samantaz Fox
4752e16ad2
i18n: make multiple fixes to i18next plurals 2022-01-10 22:49:07 +01:00
Samantaz Fox
67d2635e41
i18n: Add i18next plural rules and selector 2022-01-10 22:26:45 +01:00
Samantaz Fox
71a1ad307c
i18n: Add i18next plural resolver class 2022-01-10 22:26:45 +01:00
Samantaz Fox
9a48fd81a3
i18n: Add i18next plurals base sets 2022-01-10 22:26:45 +01:00
Samantaz Fox
790b7afcca
Fix indefinitely growing database 2022-01-09 22:04:10 +01:00
matthewmcgarvey
4962c00ba8 Update to fetch related channels again 2022-01-08 12:31:16 -06:00
bbielsa
6764185543
Add explicit return keyword 2022-01-08 18:07:07 +01:00
bbielsa
0a66a68db8
Move require statement to the correct file 2022-01-08 18:07:07 +01:00
bbielsa
8d47ec714e
Add text/xml as a possible mime type for xml file uploads 2022-01-08 18:07:07 +01:00