[idd] helper: implement mode deletion

idd/LGIddHelper/CConfigWindow.cpp

@@ -102,7 +102,7 @@ LRESULT CConfigWindow::onCreate()
 
   m_modeGroup.reset(new CGroupBox(L"Custom modes", WS_CHILD | WS_VISIBLE, m_hwnd));
 
-  m_modeBox.reset(new CListBox(WS_CHILD | WS_VISIBLE | WS_VSCROLL | LBS_NOTIFY, m_hwnd));
+  m_modeBox.reset(new CListBox(WS_CHILD | WS_VISIBLE | LBS_NOTIFY, m_hwnd));
   if (m_modes)
     updateModeList();
 
@@ -185,17 +185,9 @@ LRESULT CConfigWindow::onCommand(WORD id, WORD code, HWND hwnd)
 
     int index = m_modeBox->getData(sel);
     auto &mode = index >= 0 ? (*m_modes)[index] : m_modes->emplace_back();
-
-    try
-    {
-      mode.width = m_modeWidth->getNumericValue();
-      mode.height = m_modeHeight->getNumericValue();
-      mode.refresh = m_modeRefresh->getNumericValue();
-    }
-    catch (std::logic_error&)
-    {
-      return 0;
-    }
+    mode.width = m_modeWidth->getNumericValue();
+    mode.height = m_modeHeight->getNumericValue();
+    mode.refresh = m_modeRefresh->getNumericValue();
 
     if (index >= 0)
       m_modeBox->delItem(sel);

idd/LGIddHelper/CNotifyWindow.cpp

@@ -51,7 +51,6 @@ LRESULT CNotifyWindow::handleMessage(UINT uMsg, WPARAM wParam, LPARAM lParam)
   {
   case WM_NOTIFY_ICON:
     return onNotifyIcon(LOWORD(lParam), HIWORD(lParam), GET_X_LPARAM(wParam), GET_Y_LPARAM(wParam));
-
   case WM_CLEAN_UP_CONFIG:
     if (m_config && !m_config->hwnd())
     {
@@ -59,7 +58,6 @@ LRESULT CNotifyWindow::handleMessage(UINT uMsg, WPARAM wParam, LPARAM lParam)
       m_config.reset();
     }
     return 0;
-
   default:
     if (s_taskbarCreated && uMsg == s_taskbarCreated)
     {
@@ -72,9 +70,6 @@ LRESULT CNotifyWindow::handleMessage(UINT uMsg, WPARAM wParam, LPARAM lParam)
 
 LRESULT CNotifyWindow::onCreate()
 {
-  // Allow explorer to send us this message to register the notification icon.
-  ChangeWindowMessageFilterEx(m_hwnd, s_taskbarCreated, MSGFLT_ALLOW, NULL);
-
   registerIcon();
   return 0;
 }
@@ -134,10 +129,7 @@ void CNotifyWindow::registerIcon()
   StringCbCopy(m_iconData.szTip, sizeof m_iconData.szTip, L"Looking Glass (IDD)");
 
   if (!Shell_NotifyIcon(NIM_ADD, &m_iconData))
-  {
     DEBUG_ERROR_HR(GetLastError(), "Shell_NotifyIcon(NIM_ADD)");
-    return;
-  }
 
   if (!Shell_NotifyIcon(NIM_SETVERSION, &m_iconData))
     DEBUG_ERROR_HR(GetLastError(), "Shell_NotifyIcon(NIM_SETVERSION)");