[idd] helper: require numeric input for modes

[idd] helper: implement mode deletion
[idd] helper: fix crash when saving invalid values
2025-11-17 07:28:44 +00:00 · 2025-11-08 22:55:07 -05:00 · 2025-11-09 03:36:19 +11:00 · 2025-11-09 03:34:24 +11:00 · 2025-11-09 03:30:07 +11:00
1 changed files with 15 additions and 7 deletions
--- a/idd/LGIddHelper/CConfigWindow.cpp
+++ b/idd/LGIddHelper/CConfigWindow.cpp
@@ -102,7 +102,7 @@ LRESULT CConfigWindow::onCreate()

  m_modeGroup.reset(new CGroupBox(L"Custom modes", WS_CHILD | WS_VISIBLE, m_hwnd));

-  m_modeBox.reset(new CListBox(WS_CHILD | WS_VISIBLE | LBS_NOTIFY, m_hwnd));
+  m_modeBox.reset(new CListBox(WS_CHILD | WS_VISIBLE | WS_VSCROLL | LBS_NOTIFY, m_hwnd));
  if (m_modes)
    updateModeList();

@@ -110,9 +110,9 @@ LRESULT CConfigWindow::onCreate()
  m_heightLabel.reset(new CStaticWidget(L"Height:", WS_CHILD | WS_VISIBLE | SS_CENTERIMAGE, m_hwnd));
  m_refreshLabel.reset(new CStaticWidget(L"Refresh:", WS_CHILD | WS_VISIBLE | SS_CENTERIMAGE, m_hwnd));

-  m_modeWidth.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT, m_hwnd));
-  m_modeHeight.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT, m_hwnd));
-  m_modeRefresh.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT, m_hwnd));
+  m_modeWidth.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT | ES_NUMBER, m_hwnd));
+  m_modeHeight.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT | ES_NUMBER, m_hwnd));
+  m_modeRefresh.reset(new CEditWidget(WS_CHILD | WS_VISIBLE | ES_LEFT | ES_NUMBER, m_hwnd));

  m_modeUpdate.reset(new CButton(L"Save", WS_CHILD | WS_VISIBLE, m_hwnd));
  m_modeDelete.reset(new CButton(L"Delete", WS_CHILD | WS_VISIBLE, m_hwnd));
@@ -185,9 +185,17 @@ LRESULT CConfigWindow::onCommand(WORD id, WORD code, HWND hwnd)

    int index = m_modeBox->getData(sel);
    auto &mode = index >= 0 ? (*m_modes)[index] : m_modes->emplace_back();
-    mode.width = m_modeWidth->getNumericValue();
-    mode.height = m_modeHeight->getNumericValue();
-    mode.refresh = m_modeRefresh->getNumericValue();
+
+    try
+    {
+      mode.width = m_modeWidth->getNumericValue();
+      mode.height = m_modeHeight->getNumericValue();
+      mode.refresh = m_modeRefresh->getNumericValue();
+    }
+    catch (std::logic_error&)
+    {
+      return 0;
+    }

    if (index >= 0)
      m_modeBox->delItem(sel);
Author	SHA1	Message	Date
Quantum	bcb9f8d308	[idd] helper: require numeric input for modes	2025-11-08 22:55:07 -05:00
Quantum	f9ecddab98	[idd] helper: implement mode deletion Some checks failed build / client (Debug, map[cc:clang cxx:clang++], libdecor) (push) Has been cancelled Details build / client (Debug, map[cc:clang cxx:clang++], xdg-shell) (push) Has been cancelled Details build / client (Debug, map[cc:gcc cxx:g++], libdecor) (push) Has been cancelled Details build / client (Debug, map[cc:gcc cxx:g++], xdg-shell) (push) Has been cancelled Details build / client (Release, map[cc:clang cxx:clang++], libdecor) (push) Has been cancelled Details build / client (Release, map[cc:clang cxx:clang++], xdg-shell) (push) Has been cancelled Details build / client (Release, map[cc:gcc cxx:g++], libdecor) (push) Has been cancelled Details build / client (Release, map[cc:gcc cxx:g++], xdg-shell) (push) Has been cancelled Details build / module (push) Has been cancelled Details build / host-linux (push) Has been cancelled Details build / host-windows-cross (push) Has been cancelled Details build / host-windows-native (push) Has been cancelled Details build / idd (push) Has been cancelled Details build / obs (clang) (push) Has been cancelled Details build / obs (gcc) (push) Has been cancelled Details build / docs (push) Has been cancelled Details	2025-11-09 03:36:19 +11:00
Quantum	fad7af7740	[idd] helper: fix crash when saving invalid values	2025-11-09 03:34:24 +11:00
Quantum	6c70e36cb1	[idd] helper: allow scrolling when mode list is long	2025-11-09 03:30:07 +11:00