Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-25 06:47:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[client] core: fix reversed logic and document the rationale for it

Browse Source 
During the refactor/rebase period with B3-next the conditional was
accidentally reversed. This would cause the cursor to be ungrabbed
simply when toggling capture mode instead of waiting for the cursor to
exit the window.
This commit is contained in:
Geoffrey McRae 2021-02-23 20:19:35 +11:00
parent a8ab559de0
commit 9e2cfb9106
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/src/core.c
View File

@ -134,10 +134,20 @@ void core_setGrabQuiet(bool enable)
g_state.ds->ungrabKeyboard();
}
if (warpSupport != LG_DS_WARP_NONE || g_params.captureInputOnly || !g_state.formatValid)
/* we need to ungrab the pointer on the following conditions
* - if the backend does not support warp as exit via window edge
* detection will never work as the cursor can not be warped out of the
* window when we release it.
* - if the format is invalid as we do not know where the guest cursor is
* which also breaks edge detection.
* - if the user has opted to use captureInputOnly mode.
*/
if (warpSupport == LG_DS_WARP_NONE || !g_state.formatValid ||
g_params.captureInputOnly)
g_state.ds->ungrabPointer();
// if exiting capture when input on capture only, we want to show the cursor
/* if exiting capture when input on capture only we need to align the local
* cursor to the guest's location before it is shown. */
if (g_params.captureInputOnly || !g_params.hideMouse)
core_alignToGuest();
}