[client] util: fix failure to check result of ftell for error

This commit is contained in:
Geoffrey McRae 2023-11-11 13:28:32 +11:00
parent 9f3f8cc5bd
commit 17fce1cf78

View File

@ -48,7 +48,6 @@ bool util_fileGetContents(const char * filename, char ** buffer, size_t * length
return false; return false;
} }
long fsize = ftell(fh);
if (fseek(fh, 0, SEEK_SET) != 0) if (fseek(fh, 0, SEEK_SET) != 0)
{ {
DEBUG_ERROR("Failed to seek"); DEBUG_ERROR("Failed to seek");
@ -56,6 +55,14 @@ bool util_fileGetContents(const char * filename, char ** buffer, size_t * length
return false; return false;
} }
long fsize = ftell(fh);
if (fsize < 0)
{
DEBUG_ERROR("Failed to get the size");
fclose(fh);
return false;
}
*buffer = malloc(fsize + 1); *buffer = malloc(fsize + 1);
if (!*buffer) if (!*buffer)
{ {