mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2026-10-02 10:53:44 +00:00
Every game message still written or read by hand is now a NetGameMsg with Serialize and Deserialize, in per-domain files: - MovementMessages: teleport, platforms (resync and its request), orient to angle, node rotation lock, gravity scale, jetpack mode, control scheme, respawn checkpoint, rails (set/start, ready, cancel, arrived), mount inventory ID, dismount complete, possession ack, ghost reference override and position, camera cycling (eCameraTargetCyclingMode moves here). - ZoneMessages: player loaded (the old PLAYER_LOADED case), ready for updates, player ready, restore to post load stats, server done loading, invalid zone transfer list, zone summary display/dismissed, level processing complete, object world state, and the localized announcement WorldMigration wrote by hand. - PlayerMessages: chat mode, GM level, LEGO score, currency, reputation, GM invis, pickup currency, zone and player statistics, chat commands, bug reports, verify ack. - ObjectMessages: fire event client/server side, notify client (zone) object, notify object, script network vars, failed preconditions, terminate interaction, set name, request use, request server object info. - QuickBuildMessages: notify state, enable, cancel. - ActivityMessages gains match response/update/request, leaderboard request and data, shooting gallery score/rotation/fire, activity state change. - MissionMessages gains MissionDialogueCancelled (a no-op, as before). The wire structs left in GameMessages.h move to their domains (tooltip and emote to Effects, loot and item use to Inventory, model build to Building, behavior sound to Property, skill sets to Skill) and gain the missing direction. The dismount logic moves to PossessorComponent::OnDismountComplete. Every inbound message is registered in the GameMessageHandler map; the switch is gone, and GameMessages.cpp only holds the GameMsg/NetGameMsg base code. Call sites build the structs (NotifyClientObject, TerminateInteraction, Teleport, PlatformResync, FireEventClientSide, NotifyObject and NotifyClientZoneObject get convenience constructors like PlayFXEffect). Dead senders are dropped: SendSetShootingGalleryParams (no callers, field order was a guess), SendTeamPickupItem (the struct already existed), SendRequestActivitySummaryLeaderboardData (the struct covers it). Verified with RemainingMessagesTests: every old Send* function is frozen verbatim in Legacy/RemainingMessagesLegacy.h and compared byte for byte (same bits, destination and broadcast flag) over grids of inputs; every old Handle* read sequence is frozen as a Read* oracle and compared with the struct's Deserialize; round trips, truncation and a golden packet. PlayerLoaded (0x00dc36f0), SetGMLevel (0x00dd6230), MissionDialogueCancelled (0x00d9cc10) and LocalizedAnnouncementServerToSingleClient (0x00f23c50) were checked against the client. Behaviour notes: an inbound message that fails to deserialize is dropped, so ParseChatMessage over MAX_MESSAGE_LENGTH is dropped instead of truncated, and PLAYER_LOADED / READY_FOR_UPDATES / MISSION_DIALOGUE_CANCELLED now read their (unused) client fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
210 lines
7.8 KiB
C++
210 lines
7.8 KiB
C++
#include "PlayerMessages.h"
|
|
|
|
#include "BitStreamUtils.h"
|
|
#include "Character.h"
|
|
#include "CharacterComponent.h"
|
|
#include "DashboardNotify.h"
|
|
#include "Database.h"
|
|
#include "Entity.h"
|
|
#include "GeneralUtils.h"
|
|
#include "IBugReports.h"
|
|
#include "PlayerReports.h"
|
|
#include "SlashCommandHandler.h"
|
|
|
|
namespace GameMessages {
|
|
void UpdateChatMode::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(level);
|
|
}
|
|
|
|
bool UpdateChatMode::Deserialize(RakNet::BitStream& bitStream) {
|
|
return bitStream.Read(level);
|
|
}
|
|
|
|
void SetGMLevel::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(bOverride);
|
|
bitStream.Write(level);
|
|
}
|
|
|
|
bool SetGMLevel::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(bOverride));
|
|
VALIDATE_READ(bitStream.Read(level));
|
|
return true;
|
|
}
|
|
|
|
void ModifyLEGOScore::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(score);
|
|
BitStreamUtils::WriteOptional(bitStream, sourceType, eLootSourceType::NONE);
|
|
}
|
|
|
|
bool ModifyLEGOScore::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(score));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, sourceType, eLootSourceType::NONE));
|
|
return true;
|
|
}
|
|
|
|
void SetCurrency::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(currency);
|
|
BitStreamUtils::WriteOptional(bitStream, lootType, LOOTTYPE_NONE);
|
|
bitStream.Write(position.x);
|
|
bitStream.Write(position.y);
|
|
bitStream.Write(position.z);
|
|
BitStreamUtils::WriteOptional(bitStream, sourceLOT, LOT_NULL);
|
|
BitStreamUtils::WriteOptional(bitStream, sourceID, LWOOBJID_EMPTY);
|
|
BitStreamUtils::WriteOptional(bitStream, sourceTradeID, 0);
|
|
BitStreamUtils::WriteOptional(bitStream, sourceType, eLootSourceType::NONE);
|
|
}
|
|
|
|
bool SetCurrency::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(currency));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, lootType, LOOTTYPE_NONE));
|
|
VALIDATE_READ(bitStream.Read(position.x));
|
|
VALIDATE_READ(bitStream.Read(position.y));
|
|
VALIDATE_READ(bitStream.Read(position.z));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, sourceLOT, LOT_NULL));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, sourceID, LWOOBJID_EMPTY));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, sourceTradeID, 0));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, sourceType, eLootSourceType::NONE));
|
|
return true;
|
|
}
|
|
|
|
void UpdateReputation::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(reputation);
|
|
}
|
|
|
|
bool UpdateReputation::Deserialize(RakNet::BitStream& bitStream) {
|
|
return bitStream.Read(reputation);
|
|
}
|
|
|
|
void ToggleGMInvis::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(bStateOut);
|
|
}
|
|
|
|
bool ToggleGMInvis::Deserialize(RakNet::BitStream& bitStream) {
|
|
return bitStream.Read(bStateOut);
|
|
}
|
|
|
|
void PickupCurrency::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(currency);
|
|
}
|
|
|
|
bool PickupCurrency::Deserialize(RakNet::BitStream& bitStream) {
|
|
return bitStream.Read(currency);
|
|
}
|
|
|
|
void PickupCurrency::Handle(Entity& entity, const SystemAddress& sysAddr) {
|
|
if (currency == 0) return;
|
|
|
|
auto* ch = entity.GetCharacter();
|
|
if (ch && entity.PickupCoins(currency)) {
|
|
ch->SetCoins(ch->GetCoins() + currency, eLootSourceType::PICKUP);
|
|
}
|
|
}
|
|
|
|
void ModifyPlayerZoneStatistic::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(bSet);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, statName);
|
|
BitStreamUtils::WriteOptional(bitStream, statValue, 0);
|
|
BitStreamUtils::WriteOptional(bitStream, zoneID, LWOMAPID_INVALID);
|
|
}
|
|
|
|
bool ModifyPlayerZoneStatistic::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(bSet));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, statName));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, statValue, 0));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional(bitStream, zoneID, LWOMAPID_INVALID));
|
|
return true;
|
|
}
|
|
|
|
void ModifyPlayerZoneStatistic::Handle(Entity& entity, const SystemAddress& sysAddr) {
|
|
// Notify the character component that something's changed
|
|
auto* characterComponent = entity.GetComponent<CharacterComponent>();
|
|
if (characterComponent != nullptr) {
|
|
characterComponent->HandleZoneStatisticsUpdate(zoneID, statName, statValue);
|
|
}
|
|
}
|
|
|
|
void UpdatePlayerStatistic::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(updateID);
|
|
BitStreamUtils::WriteOptional<int64_t>(bitStream, updateValue, 1);
|
|
}
|
|
|
|
bool UpdatePlayerStatistic::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(updateID));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional<int64_t>(bitStream, updateValue, 1));
|
|
return true;
|
|
}
|
|
|
|
void UpdatePlayerStatistic::Handle(Entity& entity, const SystemAddress& sysAddr) {
|
|
auto* characterComponent = entity.GetComponent<CharacterComponent>();
|
|
if (characterComponent != nullptr) {
|
|
characterComponent->UpdatePlayerStatistic(static_cast<StatisticID>(updateID), static_cast<uint64_t>(std::max(updateValue, static_cast<int64_t>(0))), true);
|
|
}
|
|
}
|
|
|
|
void ParseChatMessage::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(iClientState);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, wsString);
|
|
}
|
|
|
|
bool ParseChatMessage::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(iClientState));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, wsString));
|
|
return true;
|
|
}
|
|
|
|
void ParseChatMessage::Handle(Entity& entity, const SystemAddress& sysAddr) {
|
|
if (!wsString.empty() && wsString[0] == L'/') {
|
|
SlashCommandHandler::HandleChatCommand(wsString, &entity, sysAddr);
|
|
}
|
|
}
|
|
|
|
void ReportBug::Serialize(RakNet::BitStream& bitStream) const {
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, body);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, clientVersion);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, otherPlayerID);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, selection);
|
|
}
|
|
|
|
bool ReportBug::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, body));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, clientVersion));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, otherPlayerID));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, selection));
|
|
return true;
|
|
}
|
|
|
|
void ReportBug::Handle(Entity& entity, const SystemAddress& sysAddr) {
|
|
IBugReports::Info reportInfo;
|
|
// The body is stored narrowed to one byte per character, as DLU always did.
|
|
for (const auto character : body) reportInfo.body.push_back(static_cast<char>(character));
|
|
reportInfo.clientVersion = clientVersion;
|
|
reportInfo.otherPlayer = otherPlayerID;
|
|
reportInfo.selection = selection;
|
|
|
|
auto character = entity.GetCharacter();
|
|
if (character) reportInfo.characterId = character->GetID();
|
|
|
|
// Report Abuse about another player sends their ID here (and "0" otherwise); that's a player report, not a bug
|
|
if (const auto reportedId = GeneralUtils::TryParse<LWOOBJID>(reportInfo.otherPlayer).value_or(LWOOBJID_EMPTY); reportedId != LWOOBJID_EMPTY) {
|
|
PlayerReports::ReportPlayer(&entity, reportedId, reportInfo.body);
|
|
return;
|
|
}
|
|
|
|
Database::Get()->InsertNewBugReport(reportInfo);
|
|
DashboardNotify::Changed("bug_reports");
|
|
}
|
|
|
|
void VerifyAck::Serialize(RakNet::BitStream& bitStream) const {
|
|
bitStream.Write(bDifferent);
|
|
BitStreamUtils::WriteLengthPrefixed<uint32_t>(bitStream, sBitStream);
|
|
BitStreamUtils::WriteOptional<uint32_t>(bitStream, uiHandle, 0);
|
|
}
|
|
|
|
bool VerifyAck::Deserialize(RakNet::BitStream& bitStream) {
|
|
VALIDATE_READ(bitStream.Read(bDifferent));
|
|
VALIDATE_READ(BitStreamUtils::ReadLengthPrefixed<uint32_t>(bitStream, sBitStream));
|
|
VALIDATE_READ(BitStreamUtils::ReadOptional<uint32_t>(bitStream, uiHandle, 0));
|
|
return true;
|
|
}
|
|
}
|