mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2026-10-13 08:13:46 +00:00
350d35dab5
First step of moving hand written bitstream code to struct based messages (see docs/PacketArchitecture.md). No wire changes. - GameMsg is now only a server-internal event (delivered to handlers registered with RegisterMsg); NetGameMsg is a wire message with Send(sysAddr) (UNASSIGNED broadcasts), SendToClient(sysAddr) (one client, never broadcasts), WritePacket, Serialize, Deserialize and Handle. Mixing them up is now a compile error. NetGameMsgEvent<T> / DeliverLocally carry a wire message to local handlers; loot drops, pickup, the object debugger, GM invisibility and model RequestUse use them. The GM invisibility message keeps its target, so its bytes are unchanged. - Behaviour change: GameMessageHandler logs and drops messages whose Deserialize fails instead of handling them with default fields (the 4 messages already registered: RequestUse, RequestServerObjectInfo, ShootingGalleryFire, PickupItem). - LUBitStream (kept as on main) gets a virtual destructor (Mail deleted derived packets through the base) and WritePacket, also used by ChatPackets::SendRoutedMsg with identical bytes. - BitStreamUtils::WriteOptional/ReadOptional for default-flag fields and WriteLengthPrefixed/ReadLengthPrefixed for length prefixed strings. - Every message ID enumerator (MessageType::*, ServiceType, Mail's wire enums) is pinned with static_asserts, so renumbering or removing one fails to compile. - Tests: dServerMock copies each sent packet (it kept a pointer to the caller's destroyed BitStream); PacketTestUtils.h compares packets bit for bit; helper tests use hand computed golden bytes and equality with the hand written patterns they replace; compile-time checks keep the wire/internal split in place. - docs/PacketArchitecture.md: survey, target architecture, conventions, verification method and migration plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
43 lines
1.1 KiB
CMake
43 lines
1.1 KiB
CMake
set(DCOMMONTEST_SOURCES
|
|
"AMFDeserializeTests.cpp"
|
|
"Amf3Tests.cpp"
|
|
"ToUnderlyingTests.cpp"
|
|
"HeaderSkipTest.cpp"
|
|
"TestCDFeatureGatingTable.cpp"
|
|
"TestLDFFormat.cpp"
|
|
"TestNiPoint3.cpp"
|
|
"TestEncoding.cpp"
|
|
"TestLUString.cpp"
|
|
"TestLUWString.cpp"
|
|
"TestBitStreamUtils.cpp"
|
|
"MessageIdPinTests.cpp"
|
|
"dCommonDependencies.cpp"
|
|
"LxfmlTests.cpp"
|
|
)
|
|
|
|
add_subdirectory(dEnumsTests)
|
|
list(APPEND DCOMMONTEST_SOURCES ${DENUMS_TESTS})
|
|
|
|
# Set our executable
|
|
add_executable(dCommonTests ${DCOMMONTEST_SOURCES})
|
|
|
|
# Needs to be in binary dir for ctest
|
|
if(APPLE)
|
|
add_custom_target(dCommonTestsLink
|
|
${CMAKE_COMMAND} -E copy $<TARGET_FILE:MariaDB::ConnCpp> ${CMAKE_CURRENT_BINARY_DIR})
|
|
|
|
add_dependencies(dCommonTests dCommonTestsLink)
|
|
endif()
|
|
|
|
# Link needed libraries
|
|
target_link_libraries(dCommonTests ${COMMON_LIBRARIES} GTest::gtest_main)
|
|
|
|
# Copy test files to testing directory
|
|
add_subdirectory(TestBitStreams)
|
|
file(COPY ${TESTBITSTREAMS} DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
|
|
add_subdirectory(LxfmlTestFiles)
|
|
file(COPY ${LXFMLTESTFILES} DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
|
|
|
|
# Discover the tests
|
|
gtest_discover_tests(dCommonTests)
|