mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2024-11-10 10:18:21 +00:00
a2ca273370
* Add failArmor server side Address out of bounds reading in behavior Address the basicAttackBehavior reading out of bounds memory and reading bits that didnt exist, which occasionally caused crashes and also caused the behavior to do undefined behavior due to the bad reads. Tested that attacking a wall anywhere with a projectile now does not crash the game. Tested with logs that the behavior correctly returned when there were no allocated bits or returned when other states were met. Add back logs and add fail handle Remove comment block Revert "Add back logs and add fail handle" This reverts commit db19be0906fc8bf35bf89037e2bfba39f5ef9c0c. Split out checks * Cleanup Behavior streams
40 lines
1.2 KiB
C++
40 lines
1.2 KiB
C++
#include "ChainBehavior.h"
|
|
#include "BehaviorBranchContext.h"
|
|
#include "Game.h"
|
|
#include "dLogger.h"
|
|
|
|
void ChainBehavior::Handle(BehaviorContext* context, RakNet::BitStream* bitStream, const BehaviorBranchContext branch) {
|
|
uint32_t chainIndex{};
|
|
|
|
if (!bitStream->Read(chainIndex)) {
|
|
Game::logger->Log("ChainBehavior", "Unable to read chainIndex from bitStream, aborting Handle! %i", bitStream->GetNumberOfUnreadBits());
|
|
return;
|
|
}
|
|
|
|
chainIndex--;
|
|
|
|
if (chainIndex < this->m_behaviors.size()) {
|
|
this->m_behaviors.at(chainIndex)->Handle(context, bitStream, branch);
|
|
} else {
|
|
Game::logger->Log("ChainBehavior", "chainIndex out of bounds, aborting handle of chain %i bits unread %i", chainIndex, bitStream->GetNumberOfUnreadBits());
|
|
}
|
|
}
|
|
|
|
void ChainBehavior::Calculate(BehaviorContext* context, RakNet::BitStream* bitStream, const BehaviorBranchContext branch) {
|
|
bitStream->Write(1);
|
|
|
|
this->m_behaviors.at(0)->Calculate(context, bitStream, branch);
|
|
}
|
|
|
|
void ChainBehavior::Load() {
|
|
const auto parameters = GetParameterNames();
|
|
|
|
for (const auto& parameter : parameters) {
|
|
if (parameter.first.rfind("behavior", 0) == 0) {
|
|
auto* action = GetAction(parameter.second);
|
|
|
|
this->m_behaviors.push_back(action);
|
|
}
|
|
}
|
|
}
|