feat(skills): save running skill cooldown groups (charxml <skil sc>)

The client reads the cooldowns still running from the charxml on load
(LWOSkillComponent::LoadFromSaveData 0x00c2a9c0): <skil sc="..."> split
on ';' and ':' (the delimiter string at 0x015b1714 is L";:") into a
cooldown group and the seconds left, each put in its cooldown map under
{hasCooldownGroup = 1, group}, the key it checks when the player casts a
skill of that group (0x00c11400). Live wrote <skil/> with nothing running
and e.g. <skil sc="17:15.6958;"/> otherwise (226 live charxmls; groups
8, 17 and 78 seen, the times below the groups' SkillBehavior cooldowns).
The claude-client-re-docs page described sc as "id;time" pairs; the
live saves and the delimiters show "group:time;".

DLU wrote no <skil>, so relogging or changing zones cleared every
cooldown (e.g. the 90 s imagination and faction skills).

- A player's successful cast (CastPlayerSkill) starts its
  SkillBehavior.cooldowngroup's cooldown (groups 0 and up, cooldown > 0),
  counted down in Update.
- Saved as live wrote it; loaded back when the player's SkillComponent
  is created, so a cooldown survives several zone changes. Old saves
  without <skil> load with none running.

Check in game: use a skill with a long cooldown (e.g. a faction kit's
special skill, a consumable with a cooldown), change zones or log out and
back in right away: its cooldown is still shown and counts down from
where it was (minus the loading time on the server).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-29 03:28:14 -05:00
parent 3c7f93dac4
commit fd2be18161
4 changed files with 129 additions and 1 deletions

View File

@@ -4,6 +4,8 @@
*/
#include "SkillComponent.h"
#include "GeneralUtils.h"
#include "tinyxml2.h"
#include <sstream>
#include <vector>
@@ -47,9 +49,51 @@ bool SkillComponent::CastPlayerSkill(const uint32_t behaviorId, const uint32_t s
context->ExecuteUpdates();
if (!context->failed && m_Parent->IsPlayer()) StartCooldown(skillID);
return !context->failed;
}
void SkillComponent::StartCooldown(const uint32_t skillID) {
const auto& skill = CDClientManager::GetTable<CDSkillBehaviorTable>()->GetSkillByID(skillID);
// The client keys cooldown groups 0 and up (a null group is -1); skills without a cooldown have none running
const auto group = static_cast<int32_t>(skill.cooldowngroup);
if (group < 0 || skill.cooldown <= 0.0f) return;
auto& left = m_CooldownGroups[group];
left = std::max(left, skill.cooldown);
}
void SkillComponent::LoadFromXml(const tinyxml2::XMLDocument& doc) {
m_CooldownGroups.clear();
const auto* const obj = doc.FirstChildElement("obj");
const auto* const skil = obj ? obj->FirstChildElement("skil") : nullptr;
const char* const cooldowns = skil ? skil->Attribute("sc") : nullptr;
if (!cooldowns) return;
// Alternating group and seconds, split on ';' and ':' as the client does
const auto tokens = GeneralUtils::SplitString(std::string(cooldowns), ';');
for (const auto& entry : tokens) {
const auto pair = GeneralUtils::SplitString(entry, ':');
if (pair.size() != 2) continue;
const auto group = GeneralUtils::TryParse<int32_t>(pair[0]);
const auto left = GeneralUtils::TryParse<float>(pair[1]);
if (group && left && *left > 0.0f) m_CooldownGroups[*group] = *left;
}
}
void SkillComponent::UpdateXml(tinyxml2::XMLDocument& doc) {
auto* const obj = doc.FirstChildElement("obj");
if (!obj) return;
auto* skil = obj->FirstChildElement("skil");
if (!skil) skil = obj->InsertNewChildElement("skil");
// Live: <skil/> with nothing running, else e.g. <skil sc="17:15.6958;"/>
std::ostringstream cooldowns;
for (const auto& [group, left] : m_CooldownGroups) cooldowns << group << ':' << left << ';';
if (cooldowns.view().empty()) skil->DeleteAttribute("sc");
else skil->SetAttribute("sc", cooldowns.str().c_str());
}
void SkillComponent::SyncPlayerSkill(const uint32_t skillUid, const uint32_t syncId, RakNet::BitStream& bitStream) {
const auto index = this->m_managedBehaviors.equal_range(skillUid);
@@ -141,6 +185,11 @@ void SkillComponent::RegisterPlayerProjectile(const LWOOBJID projectileId, Behav
}
void SkillComponent::Update(const float deltaTime) {
for (auto it = m_CooldownGroups.begin(); it != m_CooldownGroups.end();) {
it->second -= deltaTime;
it = it->second <= 0.0f ? m_CooldownGroups.erase(it) : std::next(it);
}
if (!m_Parent->HasComponent(eReplicaComponentType::BASE_COMBAT_AI) && m_Parent->GetLOT() != 1) {
CalculateUpdate(deltaTime);
}