Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2026-10-02 10:53:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: bind_ip setting for the server sockets

Browse Source 
bind_ip in sharedconfig.ini picks the local IPv4 address every server's
RakNet sockets listen on (auth, chat, master, world, the dashboard's
connection to master), separate from external_ip, the address players
are sent. Empty or 0.0.0.0 keeps listening on all interfaces; localhost
means 127.0.0.1. Anything that isn't an IPv4 address stops the server
with an error, and each server logs what it bound to.

Fixes #225

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-26 19:11:41 -05:00
parent 49fc6e06e6
commit e36f894f1f
10 changed files with 79 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/dCommonTests/BindAddressTests.cpp Normal file
View File

@@ -0,0 +1,25 @@
#include <gtest/gtest.h>
#include "GeneralUtils.h"
TEST(BindAddressTests, EmptyMeansAllInterfaces) {
EXPECT_EQ(GeneralUtils::ParseBindAddress(""), std::string{});
EXPECT_EQ(GeneralUtils::ParseBindAddress(" "), std::string{});
EXPECT_EQ(GeneralUtils::ParseBindAddress("0.0.0.0"), std::string{});
EXPECT_EQ(GeneralUtils::ParseBindAddress("*"), std::string{});
}
TEST(BindAddressTests, AcceptsIPv4) {
EXPECT_EQ(GeneralUtils::ParseBindAddress("127.0.0.1"), "127.0.0.1");
EXPECT_EQ(GeneralUtils::ParseBindAddress(" 192.168.1.20\r"), "192.168.1.20");
EXPECT_EQ(GeneralUtils::ParseBindAddress("255.255.255.255"), "255.255.255.255");
EXPECT_EQ(GeneralUtils::ParseBindAddress("localhost"), "127.0.0.1");
EXPECT_EQ(GeneralUtils::ParseBindAddress("LocalHost"), "127.0.0.1");
}
TEST(BindAddressTests, RejectsEverythingElse) {
for (const auto* bad : { "256.0.0.1", "1.2.3", "1.2.3.4.5", "1..2.3", "a.b.c.d", "010.0.0.1", "-1.0.0.1",
"1.2.3.4:2000", "example.com", "::1", "1.2.3.4 5", "+1.2.3.4" }) {
EXPECT_FALSE(GeneralUtils::ParseBindAddress(bad).has_value()) << bad;
}
}

1
tests/dCommonTests/CMakeLists.txt
View File

@@ -28,6 +28,7 @@ set(DCOMMONTEST_SOURCES
"HotPropertySlotsTests.cpp"
"PropertyRentRulesTests.cpp"
"PropertyReputationRulesTests.cpp"
"BindAddressTests.cpp"
)
add_subdirectory(dEnumsTests)