fix(character): the character data packet sends txfring=true, as live

LWOInventoryComponent_Client::LoadConfigData (0x00cde200) reads txfring
from the character data; without it the client runs its inventory-full
tips (msgPlayerReady 0x00bde5e0) on every world load. Of 226 captured
live character data packets, 222 had the key, all true; the server never
wrote it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-10-02 10:33:01 -05:00
parent 0b5a79cf96
commit df3f46b43b
4 changed files with 24 additions and 0 deletions

View File

@@ -309,6 +309,7 @@ TEST_F(WorldPacketsTests, CreateCharacterMatchesLegacy) {
packet.chatMode = static_cast<int32_t>(gm);
packet.reputation = reputation;
packet.propertyCloneID = cloneID;
packet.txfring = false; // the legacy sender never wrote it
ExpectSameSend([&](const SystemAddress& a) { LegacyWorldPackets::SendCreateCharacter(a, reputation, objectID, xml, name, gm, cloneID); }, packet);
const auto copy = RoundTrip(packet);
@@ -329,6 +330,16 @@ TEST_F(WorldPacketsTests, CreateCharacterMatchesLegacy) {
ExpectTruncatedFails(packet);
}
// Live sent txfring=true in every character data packet (222 of the 222 that had the key, of 226)
TEST_F(WorldPacketsTests, CreateCharacterSendsTxfring) {
ClientPackets::CreateCharacter packet;
EXPECT_TRUE(packet.txfring);
EXPECT_TRUE(RoundTrip(packet).txfring);
packet.txfring = false;
EXPECT_FALSE(RoundTrip(packet).txfring);
}
TEST_F(WorldPacketsTests, CharacterListMatchesLegacy) {
FakeCharacter first;
FakeCharacter second;