Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2026-10-02 02:43:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: property reputation from visitors, resistant to farming

Browse Source 
Property worlds now give their property reputation for the time other people spend on it, which
fills the property lists and the news screen's Today's Top Properties. Visitors are counted per
account; the owner's account, accounts linked to it and staff don't count. A visit earns nothing
for the first property_reputation_min_visit seconds (WorldConfig's propertyReputationDelay), then
each active minute (the visitor moved) earns reputationPerMinute times a multiplier, for a capped
number of minutes per visit. Repeat visitors earn less the more recent days they already gave
reputation, and each visitor and each property have a daily cap. Every parameter is a setting;
what each account gave each property per day is kept in property_reputation_visits. The rules are
pure functions with unit tests.

Fixes #636
Fixes #637

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-26 23:36:57 -05:00
parent 680615ba9f
commit d95eab1212
23 changed files with 684 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/dDatabaseTests/DatabaseParityTests.cpp
View File

@@ -1417,6 +1417,28 @@ TEST_F(ParitySeeded, PropertyRent) {
});
}
TEST_F(ParitySeeded, PropertyReputation) {
const auto before = Both("reputation before", [](GameDatabase& db) { return db.GetPropertyInfo(PROP2)->reputation; });
Both("AddPropertyReputation", [](GameDatabase& db) {
db.AddPropertyReputation(PROP2, 1, 20000, 5, 300);
db.AddPropertyReputation(PROP2, 1, 20000, 3, 120);
db.AddPropertyReputation(PROP2, 1, 19990, 7, 600);
db.AddPropertyReputation(PROP2, 1, 19950, 9, 600); // outside a 30 day window
db.AddPropertyReputation(PROP2, 1, 19995, 0, 60); // time without points: not a repeat day
db.AddPropertyReputation(PROP2, 2, 20000, 4, 240);
return db.GetPropertyInfo(PROP2)->reputation;
});
EXPECT_EQ(Both("reputation after", [](GameDatabase& db) { return db.GetPropertyInfo(PROP2)->reputation; }).get<int64_t>() - before.get<int64_t>(), 28);
const auto history = Both("GetPropertyVisitorHistory", [](GameDatabase& db) {
const auto h = db.GetPropertyVisitorHistory(PROP2, 1, 20000, 30);
const auto none = db.GetPropertyVisitorHistory(PROP2, 3, 20000, 30);
return json{ h.today, h.previousDays, none.today, none.previousDays };
});
EXPECT_EQ(history, json({ 8, 1, 0, 0 }));
EXPECT_EQ(Both("GetPropertyReputationOnDay", [](GameDatabase& db) { return db.GetPropertyReputationOnDay(PROP2, 20000); }), 12);
Both("GetPropertyReputationDays", [](GameDatabase& db) { return db.GetPropertyReputationDays(PROP2, 19980); });
}
TEST_F(ParitySeeded, Contraband) {
Both("GetContrabandItems empty", [](GameDatabase& db) { return db.GetContrabandItems(); });
Both("SetContrabandItem", [](GameDatabase& db) {