Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2025-09-05 14:58:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

reinterpret_cast-based type-punning is almost always UB

Browse Source
This commit is contained in:
jadebenn
2024-11-23 02:29:11 -08:00
parent 8eb3488812
commit 7740bbbaab
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
dScripts/02_server/Map/AG/NpcAgCourseStarter.cpp
View File

@@ -50,9 +50,9 @@ void NpcAgCourseStarter::OnMessageBoxResponse(Entity* self, Entity* sender, int3
if (data->values[1] != 0) return;
time_t startTime = std::time(0) + 4; // Offset for starting timer
const time_t startTime = std::time(0) + 4; // Offset for starting timer
data->values[1] = *reinterpret_cast<float*>(&startTime);
std::memcpy(&data->values[1], &startTime, sizeof(float));
Game::entityManager->SerializeEntity(self);
} else if (identifier == u"FootRaceCancel") {
@@ -80,10 +80,14 @@ void NpcAgCourseStarter::OnFireEventServerSide(Entity* self, Entity* sender, std
LWOOBJID_EMPTY, "", sender->GetSystemAddress());
scriptedActivityComponent->RemoveActivityPlayerData(sender->GetObjectID());
} else if (args == "course_finish") {
time_t endTime = std::time(0);
time_t finish = (endTime - *reinterpret_cast<time_t*>(&data->values[1]));
data->values[2] = *reinterpret_cast<float*>(&finish);
const time_t endTime = std::time(0);
// Using memcpy since misaligned reads are UB
time_t startTime{};
std::memcpy(&startTime, &data->values[1], sizeof(time_t));
const time_t finish = (endTime - startTime);
std::memcpy(&data->values[2], &finish, sizeof(float));
auto* missionComponent = sender->GetComponent<MissionComponent>();
if (missionComponent != nullptr) {