fix(quickbuild): a finished quickbuild's EnableRebuild has no duration

Live sent duration 0.0 in all 744 successful EnableRebuild (cancels
carry the time spent building, which DLU already matches); DLU sent
the reset time.

Tests get EntityManager::_addEntity/_removeEntity to make an entity
built outside CreateEntity findable, and helpers that read game
messages back out of captured packets.

Check: finish a quickbuild; the build completes, the celebrate
animation plays and the built object stays up for its usual time
before resetting.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-09-29 03:09:52 -05:00
parent 44c6340294
commit 6a438ac419
6 changed files with 130 additions and 1 deletions

View File

@@ -121,6 +121,35 @@ namespace GameMessageTestUtils {
return msg;
}
// The game message ID of every captured game message, in send order; other packets are skipped.
inline std::vector<MessageType::Game> SentGameMessageIds(const std::vector<CapturedPacket>& packets) {
std::vector<MessageType::Game> ids;
for (const auto& packet : packets) {
RakNet::BitStream bitStream(const_cast<unsigned char*>(packet.bytes.data()), packet.bytes.size(), false);
LWOOBJID target{};
MessageType::Game msgId{};
if (GameMessages::NetGameMsg::ReadPacketHeader(bitStream, target, msgId)) ids.push_back(msgId);
}
return ids;
}
// Every captured game message of type T, read back with its target, in send order.
template<typename T>
std::vector<T> SentGameMessages(const std::vector<CapturedPacket>& packets) {
std::vector<T> found;
for (const auto& packet : packets) {
RakNet::BitStream bitStream(const_cast<unsigned char*>(packet.bytes.data()), packet.bytes.size(), false);
T msg;
LWOOBJID target{};
MessageType::Game msgId{};
if (!GameMessages::NetGameMsg::ReadPacketHeader(bitStream, target, msgId) || msgId != msg.msgId) continue;
EXPECT_TRUE(msg.Deserialize(bitStream));
msg.target = target;
found.push_back(msg);
}
return found;
}
// Checks that every strict prefix of msg's serialized payload fails to deserialize.
template<typename T>
void ExpectTruncatedFails(const T& msg) {