fix: the character data packet carries the world keys live sent

Every live character data packet (451 of 451) had legoclub=1, freetrial=0,
requiresrename=0, levelid and position.x/y/z + rotation.x/y/z/w next to
the keys already sent. LWOCharacterComponent::LoadConfigData (0x00c70f00)
reads requiresrename, legoclub and freetrial.

requiresrename is the character's refused-name state, levelid the zone id
(map, instance << 16, clone << 32) and the position and rotation are where
the player is put in the world.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-11-10 14:48:11 -06:00
parent e786d2b1c5
commit 55a6d0babc
5 changed files with 91 additions and 0 deletions

View File

@@ -310,6 +310,7 @@ TEST_F(WorldPacketsTests, CreateCharacterMatchesLegacy) {
packet.reputation = reputation;
packet.propertyCloneID = cloneID;
packet.txfring = false; // the legacy sender never wrote it
packet.sendWorldKeys = false; // nor the world keys
ExpectSameSend([&](const SystemAddress& a) { LegacyWorldPackets::SendCreateCharacter(a, reputation, objectID, xml, name, gm, cloneID); }, packet);
const auto copy = RoundTrip(packet);
@@ -340,6 +341,30 @@ TEST_F(WorldPacketsTests, CreateCharacterSendsTxfring) {
EXPECT_FALSE(RoundTrip(packet).txfring);
}
// Live sent legoclub=1, freetrial=0, requiresrename=0, levelid and position / rotation in 451 of 451 character data packets
TEST_F(WorldPacketsTests, CreateCharacterSendsTheWorldKeys) {
ClientPackets::CreateCharacter packet;
packet.xmlData = "<obj/>";
packet.requiresRename = true;
packet.levelID = 1200ULL | 7ULL << 16 | 99ULL << 32;
packet.position = NiPoint3(1.5f, -2.0f, 3.25f);
packet.rotation = NiQuaternion(0.5f, 0.1f, 0.2f, 0.3f);
const auto copy = RoundTrip(packet);
EXPECT_TRUE(copy.sendWorldKeys);
EXPECT_TRUE(copy.legoClub);
EXPECT_FALSE(copy.freeTrial);
EXPECT_TRUE(copy.requiresRename);
EXPECT_EQ(copy.levelID, packet.levelID);
EXPECT_EQ(copy.position, packet.position);
EXPECT_EQ(copy.rotation, packet.rotation);
packet.sendWorldKeys = false;
const auto without = RoundTrip(packet);
EXPECT_FALSE(without.sendWorldKeys);
EXPECT_FALSE(without.legoClub); // the client's value without the key
EXPECT_FALSE(without.requiresRename);
}
TEST_F(WorldPacketsTests, CharacterListMatchesLegacy) {
FakeCharacter first;
FakeCharacter second;