mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2026-10-02 10:53:44 +00:00
fix(destroyable): take template factions from factionList, keeping -1
The client reads an object's factions only from the DestructibleComponent factionList (LWODestroyableComponent::LoadDataFromTemplate 0x00c9f900: one atol per comma-separated token, -1 kept; the faction column is not read), and live replicated that list: [-1] on 12,829 constructions (vendors, quickbuilds, bouncers). DLU added the faction column and dropped -1, so those objects were sent with no factions, and the four rows with faction 6 but factionList "-1" were sent as [6]. -1 has no Factions row, so it adds no friends or enemies. Test: ReplicaConstructionTest.TemplateFactionMinusOneIsReplicated. Check in game: vendors, quickbuilds, bouncers and NPCs still can't be attacked; enemies still fight players and pets; smashables still smash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -213,6 +213,12 @@ public:
|
||||
*/
|
||||
bool GetIsShielded() const { return m_IsShielded; }
|
||||
|
||||
/**
|
||||
* Adds the factions in the object's DestructibleComponent factionList (comma separated), -1 included, as the client
|
||||
* reads them
|
||||
*/
|
||||
void AddTemplateFactions(const std::string& factionList);
|
||||
|
||||
/**
|
||||
* Adds a faction to the faction list of this entity, potentially making more factions friendly. Fetches the info
|
||||
* from the CDClient.
|
||||
|
||||
Reference in New Issue
Block a user