fix: a launch pad checks its GM level and launch precondition

LWORocketLaunchComponentCommon does not launch a player under the row's
gmLevel (msgFireEventClientSide 0x00cb78b0) or, with useLaunchPrecondition,
one that fails the row's launchPrecondition (msgCheckUseRequirements
0x00c7d0d0). The server launched on any request. Rows: the test launcher
asks for GM level 9, the pads to Gnarled Forest and Forbidden Valley for
mission 474, Starbase 3001's for mission 956.

The alternative landing precondition pointer also starts out null for a
pad without a row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-11-10 15:14:44 -06:00
parent 38fe226e6f
commit 53968599d2
3 changed files with 52 additions and 2 deletions

View File

@@ -1,6 +1,8 @@
#include "GameDependencies.h"
#include "dGameMessagesTests/GameMessageTestUtils.h"
#include "CDClientDatabase.h"
#include "Entity.h"
#include "ObjectMessages.h"
#include "RocketLaunchpadControlComponent.h"
@@ -49,3 +51,25 @@ TEST_F(RocketLaunchTests, RocketEquippedIsBroadcast) {
ASSERT_EQ(sent.size(), 1u);
EXPECT_TRUE(sent[0].broadcast);
}
// A pad's row can ask for a GM level (the AG test pad: 9); LWORocketLaunchComponentCommon::msgFireEventClientSide
// (0x00cb78b0) does not launch a player under it
TEST_F(RocketLaunchTests, APadWithAGmLevelLaunchesOnlyThoseAtIt) {
CDClientDatabase::Connect(":memory:");
CDClientDatabase::ExecuteDML("CREATE TABLE RocketLaunchpadControlComponent (id INTEGER, targetZone INTEGER, defaultZoneID INTEGER, targetScene TEXT, gmLevel INTEGER, useLaunchPrecondition INTEGER, launchPrecondition TEXT, useAltLandingPrecondition INTEGER, altLandingPrecondition TEXT, altLandingSpawnPointName TEXT);");
CDClientDatabase::ExecuteDML("INSERT INTO RocketLaunchpadControlComponent VALUES (1, 1100, 0, 'AGLaunch', 9, 0, '', 0, '', '');");
CDClientDatabase::ExecuteDML("INSERT INTO RocketLaunchpadControlComponent VALUES (2, 1200, 0, 'NS_NT', 0, 0, '47', 0, '', '');");
Entity gmPad(PAD, info);
auto* const gmOnly = gmPad.AddComponent<RocketLaunchpadControlComponent>(1);
gmOnly->LoadDataFromTemplate();
Entity openPad(PAD + 1, info);
auto* const open = openPad.AddComponent<RocketLaunchpadControlComponent>(2);
open->LoadDataFromTemplate();
Entity player(PLAYER, info);
EXPECT_FALSE(gmOnly->MayLaunch(player));
EXPECT_TRUE(open->MayLaunch(player)); // its precondition is not in use
player.SetGMLevel(eGameMasterLevel::OPERATOR);
EXPECT_TRUE(gmOnly->MayLaunch(player));
}