Refactor: Amf3 implementation (#998)

* Update AMFDeserializeTests.cpp

Redo Amf3 functionality

Overhaul the whole thing due to it being outdated and clunky to use

Sometimes you want to keep the value

Update AMFDeserializeTests.cpp

* Fix enum and constructors

Correct enum to a class and simplify names.
Add a proper default constructor

* Update MasterServer.cpp

* Fix bugs and add more tests

* Refactor: AMF with templates in mind

- Remove hard coded bodge
- Use templates and generics to allow for much looser typing and strengthened implementation
- Move code into header only implementation for portability

Refactor: Convert AMF implementation to templates

- Rip out previous implementation
- Remove all extraneous terminology
- Add proper overloads for all types of inserts
- Fix up tests and codebase

* Fix compiler errors

* Check for null first

* Add specialization for const char*

* Update tests for new template specialization

* Switch BitStream to use references

* Rename files

* Check enum bounds on deserialize

I did this on a phone

tests/dGameTests/dGameMessagesTests/GameMessageTests.cpp

@@ -1,5 +1,5 @@
 #include "Action.h"
-#include "AMFFormat.h"
+#include "Amf3.h"
 #include "AMFDeserialize.h"
 #include "GameMessages.h"
 #include "GameDependencies.h"
@@ -40,8 +40,8 @@ protected:
 	}
 	AMFArrayValue* ReadArrayFromBitStream(RakNet::BitStream* inStream) {
 		AMFDeserialize des;
-		AMFValue* readArray = des.Read(inStream);
-		EXPECT_EQ(readArray->GetValueType(), AMFValueType::AMFArray);
+		AMFBaseValue* readArray = des.Read(inStream);
+		EXPECT_EQ(readArray->GetValueType(), eAmf::Array);
 		return static_cast<AMFArrayValue*>(readArray);
 	}
 };