fix(destroyable): resurrect only a dead player that isn't already resurrecting

RequestResurrect resurrected whoever sent it, so a living player could reset
their health and imagination, and repeated requests stacked respawns. The
client's destroyable resurrects only when smashed and not resurrecting
(LWODestroyableComponent::SendMessage 0x00d29e40); live, all 17 requests in
the captures came after the player's Die and before its Resurrect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Aaron Kimbrell
2026-10-02 09:17:28 -05:00
parent cf1e8a54c6
commit 4b84677cba
4 changed files with 25 additions and 0 deletions

View File

@@ -718,3 +718,16 @@ TEST_F(DestroyableTest, DamageReductionsAddUp) {
destroyableComponent->RemoveDamageReduction(10);
EXPECT_EQ(destroyableComponent->GetDamageReduction(), 0);
}
// The client resurrects only a dead object that isn't already resurrecting; a RequestResurrect from a living player
// does nothing
TEST_F(DestroyableTest, RequestResurrectOnlyWhenDead) {
GameMessages::RequestResurrect request;
destroyableComponent->SetIsDead(false);
request.Handle(*baseEntity, UNASSIGNED_SYSTEM_ADDRESS);
EXPECT_FALSE(destroyableComponent->GetIsResurrecting());
destroyableComponent->SetIsDead(true);
request.Handle(*baseEntity, UNASSIGNED_SYSTEM_ADDRESS);
EXPECT_TRUE(destroyableComponent->GetIsResurrecting());
}