Move EntityManager to Game namespace (#1140)

* Move EntityManager to Game namespace

* move initialization to later

Need to wait for dZoneManager to be initialized.

* Fix bugs

- Cannot delete from a RandomAccessIterator while in a range based for loop.

Touchup zone manager initialize

replace magic numbers with better named constants
replace magic zonecontrol id with a more readable hex alternative
condense stack variables
move initializers closer to their use
initialize entity manager with zone control

change initialize timings

If zone is not zero we expect to initialize the entity manager during zone manager initialization

Add constexpr for zone control LOT

* Add proper error handling

* revert vanity changes

* Update WorldServer.cpp

* Update dZoneManager.cpp

tests/dGameTests/GameDependencies.cpp

@@ -1,13 +1,14 @@
 #include "GameDependencies.h"
 
 namespace Game {
-	dLogger* logger;
-	dServer* server;
-	dZoneManager* zoneManager;
-	dChatFilter* chatFilter;
-	dConfig* config;
+	dLogger* logger = nullptr;
+	dServer* server = nullptr;
+	dZoneManager* zoneManager = nullptr;
+	dChatFilter* chatFilter = nullptr;
+	dConfig* config = nullptr;
 	std::mt19937 randomEngine;
-	RakPeerInterface* chatServer;
-	AssetManager* assetManager;
+	RakPeerInterface* chatServer = nullptr;
+	AssetManager* assetManager = nullptr;
 	SystemAddress chatSysAddr;
+	EntityManager* entityManager = nullptr;
 }

tests/dGameTests/GameDependencies.h

@@ -32,11 +32,12 @@ protected:
 		Game::logger = new dLogger("./testing.log", true, true);
 		Game::server = new dServerMock();
 		Game::config = new dConfig("worldconfig.ini");
+		Game::entityManager = new EntityManager();
 	}
 
 	void TearDownDependencies() {
 		if (Game::server) delete Game::server;
-		delete EntityManager::Instance();
+		if (Game::entityManager) delete Game::entityManager;
 		if (Game::logger) {
 			Game::logger->Flush();
 			delete Game::logger;
@@ -44,7 +45,7 @@ protected:
 		if (Game::config) delete Game::config;
 	}
 
-	EntityInfo info;
+	EntityInfo info{};
 };
 
 #endif //!__GAMEDEPENDENCIES__H__