address feedback

This commit is contained in:
Aaron Kimbre 2023-11-10 22:01:25 -06:00
parent 4c3949e5d8
commit 175b354e68

View File

@ -32,8 +32,8 @@ void VanityUtilities::SpawnVanity() {
} }
const uint32_t zoneID = Game::server->GetZoneID(); const uint32_t zoneID = Game::server->GetZoneID();
if (!m_NPCs.empty()){
for (auto& npc : m_NPCs) { for (const auto& npc : m_NPCs) {
if (npc.m_ID == LWOOBJID_EMPTY) continue; if (npc.m_ID == LWOOBJID_EMPTY) continue;
if (npc.m_LOT == 176){ if (npc.m_LOT == 176){
Game::zoneManager->RemoveSpawner(npc.m_ID); Game::zoneManager->RemoveSpawner(npc.m_ID);
@ -43,15 +43,10 @@ void VanityUtilities::SpawnVanity() {
entity->Smash(LWOOBJID_EMPTY, eKillType::VIOLENT); entity->Smash(LWOOBJID_EMPTY, eKillType::VIOLENT);
} }
} }
m_NPCs.clear();
}
if (!m_Parties.empty()){ m_NPCs.clear();
m_Parties.clear(); m_Parties.clear();
}
if (!m_PartyPhrases.empty()){
m_PartyPhrases.clear(); m_PartyPhrases.clear();
}
ParseXML((BinaryPathFinder::GetBinaryDir() / "vanity/NPC.xml").string()); ParseXML((BinaryPathFinder::GetBinaryDir() / "vanity/NPC.xml").string());