mirror of
https://github.com/DarkflameUniverse/DarkflameServer.git
synced 2026-11-18 09:45:28 +00:00
fix(master): a cut password skips what it cut, and a starting private instance answers once ready
A capped string now skips the characters it cut, so what follows it is read from the right place. A request to join a private instance that is still starting is answered once its world server is ready, instead of at once with an address nothing listens on yet. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This commit is contained in:
@@ -720,3 +720,20 @@ TEST(MasterPacketsTests, ServerListWithoutOutdatedFlags) {
|
||||
ASSERT_TRUE(withFlag.Deserialize(again));
|
||||
EXPECT_EQ(withFlag.instances[0].outdated, 1);
|
||||
}
|
||||
|
||||
// A password longer than master keeps is cut, and the characters cut are skipped: nothing of it is left to be read
|
||||
// as what follows
|
||||
TEST(MasterPacketsTests, CappedPasswordSkipsWhatItCut) {
|
||||
for (const auto& password : g_Strings) {
|
||||
MasterPackets::CreatePrivateZone sent;
|
||||
sent.zoneID = 1100;
|
||||
sent.cloneID = 7;
|
||||
sent.password = password;
|
||||
RakNet::BitStream stream;
|
||||
LoadPayload(stream, sent);
|
||||
MasterPackets::CreatePrivateZone read;
|
||||
ASSERT_TRUE(read.Deserialize(stream));
|
||||
EXPECT_EQ(read.password, password.substr(0, MasterPackets::CreatePrivateZone::MAX_PASSWORD_LENGTH));
|
||||
EXPECT_EQ(stream.GetNumberOfUnreadBits(), 0u);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user