Mirrored_Repos/DarkflameServer
1
0
Fork 0
mirror of https://github.com/DarkflameUniverse/DarkflameServer.git synced 2025-04-26 16:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

default-initialize message-id buffer to an invalid (but defined) state and trust the compiler to optimize it out

Browse Source
This commit is contained in:
jadebenn 2024-11-21 18:48:02 -06:00
parent 5aa8b1395b
commit 051a0ba05e
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dCommon/dEnums/MessageType/World.h
View File

@ -5,7 +5,8 @@
namespace MessageType {
enum class World : uint32_t {
VALIDATION = 1, // Session info
INVALID = 0,
VALIDATION, // Session info
CHARACTER_LIST_REQUEST,
CHARACTER_CREATE_REQUEST,
LOGIN_REQUEST, // Character selected

2
dWorldServer/WorldServer.cpp
View File

@ -1397,7 +1397,7 @@ void HandlePacket(Packet* packet) {
default:
// Need to use memcpy instead of reinterpret_cast to avoid UB
MessageType::World messageId;
auto messageId = MessageType::World::INVALID;
std::memcpy(&messageId, &packet->data[3], sizeof(MessageType::World));
const std::string_view messageIdString = StringifiedEnum::ToString(messageId);