mirror of
https://github.com/yattee/yattee.git
synced 2026-10-23 21:22:53 +00:00
A fresh device never adopted the synced context. The local value is a default stamped when the manager is built, so it is always newer than a choice made on another device, and ordering against it discarded that choice. With no local decision to protect, the first synced context is simply adopted. An account arriving mid-session sat at "sign in required" until the app was relaunched: nothing recomputed its status once the metadata — or its instance — turned up, even when iCloud Keychain had already delivered the credential. Both arrivals now recompute statuses and re-run the legacy mirror, which was similarly stuck whenever the instance had not arrived yet. Signing in again keeps the same account and the same context, so nothing downstream saw a change — but the credential may now belong to somebody else, and their subscriptions and feed stayed on screen. The provider and the account's caches are discarded on every credential replacement. The deletion repair also cancels a context upload the deleted choice had queued; sending it would have published the fallback under that choice's timestamp, which not stamping it "now" exists to prevent. Piped subscribe/unsubscribe and Invidious unsubscribe now report their outcome like every other authenticated call, so a credential rejected by one of them stops claiming to be signed in. Removing the last account updates the source screen, which kept offering authenticated imports that could only fail.
179 lines
6.5 KiB
Swift
179 lines
6.5 KiB
Swift
//
|
|
// PipedSubscriptionProvider.swift
|
|
// Yattee
|
|
//
|
|
// Piped subscription provider that manages subscriptions on a Piped instance.
|
|
// Uses in-memory cache only - does NOT persist to SwiftData to avoid corrupting local subscriptions.
|
|
//
|
|
|
|
import Foundation
|
|
|
|
/// Piped subscription provider that syncs with a Piped instance account.
|
|
/// Subscriptions are managed on the Piped server and kept in memory only.
|
|
/// This provider does NOT write to SwiftData to preserve local subscriptions.
|
|
@MainActor
|
|
final class PipedSubscriptionProvider: SubscriptionProvider {
|
|
// MARK: - Properties
|
|
|
|
/// The account this provider is bound to. One provider per account, so two
|
|
/// logins on the same instance never share a subscription cache.
|
|
let account: Account
|
|
var context: DataContext { .account(account.id) }
|
|
|
|
private let pipedAPI: PipedAPI
|
|
private let credentialsManager: PipedCredentialsManager
|
|
private let accountsManager: AccountsManager
|
|
|
|
/// Records the outcome of a server call against the account.
|
|
///
|
|
/// Deliberately conservative: a raw 401 marks the credential rejected only
|
|
/// when no reverse-proxy basic auth is configured, because otherwise the
|
|
/// 401 may well have come from the proxy rather than the account. The
|
|
/// two-stage probe that disambiguates the remaining case is Phase 2 work;
|
|
/// until then an ambiguous failure leaves the status untouched rather than
|
|
/// wrongly telling the user to sign in again.
|
|
private func recordOutcome(_ error: Error?) {
|
|
guard let error else {
|
|
accountsManager.setStatus(.signedIn, for: account.id)
|
|
return
|
|
}
|
|
|
|
guard case APIError.unauthorized = error else { return }
|
|
guard accountsManager.instance(for: account)?.usesBasicAuth == false else { return }
|
|
|
|
accountsManager.setStatus(.credentialRejected, for: account.id)
|
|
}
|
|
private let settingsManager: SettingsManager
|
|
|
|
/// In-memory cache of subscribed channel IDs for fast lookup.
|
|
private var cachedChannelIDs: Set<String> = []
|
|
|
|
/// In-memory cache of full channel data for display.
|
|
private var cachedChannels: [Channel] = []
|
|
|
|
/// Whether the cache has been populated from the server.
|
|
private var cachePopulated = false
|
|
|
|
// MARK: - Initialization
|
|
|
|
init(
|
|
account: Account,
|
|
pipedAPI: PipedAPI,
|
|
credentialsManager: PipedCredentialsManager,
|
|
accountsManager: AccountsManager,
|
|
settingsManager: SettingsManager
|
|
) {
|
|
self.account = account
|
|
self.pipedAPI = pipedAPI
|
|
self.credentialsManager = credentialsManager
|
|
self.accountsManager = accountsManager
|
|
self.settingsManager = settingsManager
|
|
}
|
|
|
|
// MARK: - SubscriptionProvider
|
|
|
|
func fetchSubscriptions() async throws -> [Channel] {
|
|
let (instance, authToken) = try await getAuthenticatedInstance()
|
|
|
|
// Fetch subscriptions from Piped
|
|
let subscriptions = try await tracking {
|
|
try await pipedAPI.subscriptions(instance: instance, authToken: authToken)
|
|
}
|
|
|
|
// Update in-memory cache
|
|
cachedChannelIDs = Set(subscriptions.map(\.channelId))
|
|
cachedChannels = subscriptions.map { $0.toChannel() }
|
|
cachePopulated = true
|
|
|
|
LoggingService.shared.info("Fetched \(subscriptions.count) Piped subscriptions", category: .api)
|
|
|
|
return cachedChannels
|
|
}
|
|
|
|
func subscribe(to channel: Channel) async throws {
|
|
let (instance, authToken) = try await getAuthenticatedInstance()
|
|
|
|
// Subscribe on Piped server. Tracked like every other authenticated
|
|
// call: a rejected credential noticed here must mark the account, or it
|
|
// keeps reporting itself as signed in.
|
|
try await tracking {
|
|
try await pipedAPI.subscribe(channelID: channel.id.channelID, instance: instance, authToken: authToken)
|
|
}
|
|
|
|
// Update in-memory cache only
|
|
cachedChannelIDs.insert(channel.id.channelID)
|
|
if !cachedChannels.contains(where: { $0.id.channelID == channel.id.channelID }) {
|
|
cachedChannels.append(channel)
|
|
}
|
|
|
|
LoggingService.shared.info("Subscribed to \(channel.name) on Piped", category: .api)
|
|
}
|
|
|
|
func unsubscribe(from channelID: String) async throws {
|
|
let (instance, authToken) = try await getAuthenticatedInstance()
|
|
|
|
// Unsubscribe on Piped server
|
|
try await tracking {
|
|
try await pipedAPI.unsubscribe(channelID: channelID, instance: instance, authToken: authToken)
|
|
}
|
|
|
|
// Update in-memory cache only
|
|
cachedChannelIDs.remove(channelID)
|
|
cachedChannels.removeAll { $0.id.channelID == channelID }
|
|
|
|
LoggingService.shared.info("Unsubscribed from \(channelID) on Piped", category: .api)
|
|
}
|
|
|
|
func isSubscribed(to channelID: String) async -> Bool {
|
|
// If cache isn't populated yet, try to refresh it
|
|
if !cachePopulated {
|
|
do {
|
|
_ = try await fetchSubscriptions()
|
|
} catch {
|
|
// Can't determine subscription status without server connection
|
|
return false
|
|
}
|
|
}
|
|
return cachedChannelIDs.contains(channelID)
|
|
}
|
|
|
|
func refreshCache() async throws {
|
|
// Simply fetch subscriptions again - this updates in-memory cache
|
|
_ = try await fetchSubscriptions()
|
|
}
|
|
|
|
var cachedSubscriptionCount: Int? {
|
|
cachePopulated ? cachedChannels.count : nil
|
|
}
|
|
|
|
// MARK: - Private Helpers
|
|
|
|
/// Gets the authenticated Piped instance and auth token from account settings.
|
|
/// Runs a server call and records what it implies about the credential.
|
|
private func tracking<T>(_ operation: () async throws -> T) async rethrows -> T {
|
|
do {
|
|
let value = try await operation()
|
|
recordOutcome(nil)
|
|
return value
|
|
} catch {
|
|
recordOutcome(error)
|
|
throw error
|
|
}
|
|
}
|
|
|
|
private func getAuthenticatedInstance() async throws -> (Instance, String) {
|
|
// The account names its instance directly - no falling back to
|
|
// "some enabled Piped instance", which could silently send one
|
|
// account's request to a server it has no credential for.
|
|
guard let instance = accountsManager.instance(for: account), instance.isEnabled else {
|
|
throw SubscriptionProviderError.instanceNotConfigured
|
|
}
|
|
|
|
guard let authToken = credentialsManager.credential(for: account) else {
|
|
throw SubscriptionProviderError.notAuthenticated
|
|
}
|
|
|
|
return (instance, authToken)
|
|
}
|
|
}
|