mirror of
https://github.com/yattee/yattee.git
synced 2025-11-13 13:48:48 +00:00
f4d4daccd0
This commit addresses multiple SwiftUI performance bottlenecks identified through code analysis, focusing on view rendering efficiency, list performance, and memory usage optimization. Key improvements: - HomeView: Optimize async task management using structured concurrency with async let to handle multiple Defaults updates in a single task - VideoCell: Remove GeometryReader from VideoCellThumbnail to eliminate layout thrashing; change @ObservedObject to computed property for shared ThumbnailsModel - ThumbnailView: Cache URL extension computation in init() instead of recalculating on every body evaluation - FavoriteItemView: Replace filter().prefix() with early-exit loop and capacity reservation for significant performance gain on large lists - ContentItemView: Optimize FetchRequest creation with direct predicate construction only for video items, empty predicate for others - VideoPlayerView: Fix playerSize didSet trigger by moving updateSidebarQueue() calls to explicit onChange/onAppear handlers - FeedView: Replace .unique() with Set-based deduplication for O(n) performance and reduced allocations - VerticalCells: Remove expensive sorting on every redraw; items should be pre-sorted from source These optimizations follow SwiftUI best practices by minimizing expensive computations in view bodies, caching computed values, using efficient data structures, and avoiding unnecessary redraws and layout passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
81 lines
2.2 KiB
Swift
81 lines
2.2 KiB
Swift
import CachedAsyncImage
|
|
import SDWebImageSwiftUI
|
|
import SwiftUI
|
|
|
|
struct ThumbnailView: View {
|
|
var url: URL?
|
|
private let thumbnails = ThumbnailsModel.shared
|
|
private let thumbnailExtension: String?
|
|
|
|
init(url: URL?) {
|
|
self.url = url
|
|
self.thumbnailExtension = Self.extractExtension(from: url)
|
|
}
|
|
|
|
private static func extractExtension(from url: URL?) -> String? {
|
|
guard let url,
|
|
let urlComponents = URLComponents(url: url, resolvingAgainstBaseURL: false) else { return nil }
|
|
|
|
let pathComponents = urlComponents.path.components(separatedBy: ".")
|
|
guard pathComponents.count > 1 else { return nil }
|
|
|
|
return pathComponents.last
|
|
}
|
|
|
|
var body: some View {
|
|
if url != nil {
|
|
viewForThumbnailExtension
|
|
} else {
|
|
placeholder
|
|
}
|
|
}
|
|
|
|
@ViewBuilder var viewForThumbnailExtension: some View {
|
|
if AccountsModel.shared.app != .piped, thumbnailExtension != nil {
|
|
if thumbnailExtension == "webp" {
|
|
webImage
|
|
} else {
|
|
asyncImageIfAvailable
|
|
}
|
|
} else {
|
|
webImage
|
|
}
|
|
}
|
|
|
|
var webImage: some View {
|
|
WebImage(url: url)
|
|
.resizable()
|
|
.onFailure { _ in
|
|
if let url {
|
|
thumbnails.insertUnloadable(url)
|
|
}
|
|
}
|
|
.placeholder { placeholder }
|
|
}
|
|
|
|
@ViewBuilder var asyncImageIfAvailable: some View {
|
|
if #available(iOS 15, macOS 12, *) {
|
|
CachedAsyncImage(url: url, urlCache: BaseCacheModel.imageCache) { phase in
|
|
switch phase {
|
|
case let .success(image):
|
|
image
|
|
.resizable()
|
|
case .failure:
|
|
placeholder.onAppear {
|
|
guard let url else { return }
|
|
thumbnails.insertUnloadable(url)
|
|
}
|
|
default:
|
|
placeholder
|
|
}
|
|
}
|
|
} else {
|
|
webImage
|
|
}
|
|
}
|
|
|
|
var placeholder: some View {
|
|
Rectangle().fill(Color("PlaceholderColor"))
|
|
}
|
|
}
|