mirror of
https://github.com/yattee/yattee.git
synced 2025-11-13 13:48:48 +00:00
This commit addresses multiple SwiftUI performance bottlenecks identified through code analysis, focusing on view rendering efficiency, list performance, and memory usage optimization. Key improvements: - HomeView: Optimize async task management using structured concurrency with async let to handle multiple Defaults updates in a single task - VideoCell: Remove GeometryReader from VideoCellThumbnail to eliminate layout thrashing; change @ObservedObject to computed property for shared ThumbnailsModel - ThumbnailView: Cache URL extension computation in init() instead of recalculating on every body evaluation - FavoriteItemView: Replace filter().prefix() with early-exit loop and capacity reservation for significant performance gain on large lists - ContentItemView: Optimize FetchRequest creation with direct predicate construction only for video items, empty predicate for others - VideoPlayerView: Fix playerSize didSet trigger by moving updateSidebarQueue() calls to explicit onChange/onAppear handlers - FeedView: Replace .unique() with Set-based deduplication for O(n) performance and reduced allocations - VerticalCells: Remove expensive sorting on every redraw; items should be pre-sorted from source These optimizations follow SwiftUI best practices by minimizing expensive computations in view bodies, caching computed values, using efficient data structures, and avoiding unnecessary redraws and layout passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
113 lines
3.3 KiB
Swift
113 lines
3.3 KiB
Swift
import Defaults
|
|
import SwiftUI
|
|
|
|
struct VerticalCells<Header: View>: View {
|
|
#if os(iOS)
|
|
@Environment(\.verticalSizeClass) private var verticalSizeClass
|
|
#endif
|
|
|
|
@Environment(\.loadMoreContentHandler) private var loadMoreContentHandler
|
|
@Environment(\.listingStyle) private var listingStyle
|
|
|
|
var items = [ContentItem]()
|
|
var allowEmpty = false
|
|
var edgesIgnoringSafeArea = Edge.Set.horizontal
|
|
|
|
let header: Header?
|
|
|
|
@State private var gridSize = CGSize.zero
|
|
|
|
init(
|
|
items: [ContentItem],
|
|
allowEmpty: Bool = false,
|
|
edgesIgnoringSafeArea: Edge.Set = .horizontal,
|
|
@ViewBuilder header: @escaping () -> Header? = { nil }
|
|
) {
|
|
self.items = items
|
|
self.allowEmpty = allowEmpty
|
|
self.edgesIgnoringSafeArea = edgesIgnoringSafeArea
|
|
self.header = header()
|
|
}
|
|
|
|
init(
|
|
items: [ContentItem],
|
|
allowEmpty: Bool = false
|
|
) where Header == EmptyView {
|
|
self.init(items: items, allowEmpty: allowEmpty) { EmptyView() }
|
|
}
|
|
|
|
var body: some View {
|
|
ScrollView(.vertical, showsIndicators: scrollViewShowsIndicators) {
|
|
LazyVGrid(columns: adaptiveItem, alignment: .center) {
|
|
Section(header: header) {
|
|
ForEach(contentItems) { item in
|
|
ContentItemView(item: item)
|
|
.onAppear { loadMoreContentItemsIfNeeded(current: item) }
|
|
}
|
|
}
|
|
}
|
|
.padding()
|
|
}
|
|
.animation(nil)
|
|
.edgesIgnoringSafeArea(edgesIgnoringSafeArea)
|
|
#if os(macOS)
|
|
.background(Color.secondaryBackground)
|
|
.frame(minWidth: Constants.contentViewMinWidth)
|
|
#endif
|
|
}
|
|
|
|
var contentItems: [ContentItem] {
|
|
// Avoid sorting on every redraw - items should already be sorted from the source
|
|
// If sorting is truly needed, it should be done once in the model, not in the view
|
|
items.isEmpty ? (allowEmpty ? items : ContentItem.placeholders) : items
|
|
}
|
|
|
|
func loadMoreContentItemsIfNeeded(current item: ContentItem) {
|
|
let thresholdIndex = items.index(items.endIndex, offsetBy: -5)
|
|
if items.firstIndex(where: { $0.id == item.id }) == thresholdIndex {
|
|
loadMoreContentHandler()
|
|
}
|
|
}
|
|
|
|
var adaptiveItem: [GridItem] {
|
|
if listingStyle == .list {
|
|
return [.init(.flexible())]
|
|
}
|
|
|
|
return [GridItem(.adaptive(minimum: adaptiveGridItemMinimumSize, maximum: adaptiveGridItemMaximumSize))]
|
|
}
|
|
|
|
var adaptiveGridItemMinimumSize: Double {
|
|
#if os(iOS)
|
|
return verticalSizeClass == .regular ? 320 : 800
|
|
#elseif os(tvOS)
|
|
return 600
|
|
#else
|
|
return 320
|
|
#endif
|
|
}
|
|
|
|
var adaptiveGridItemMaximumSize: Double {
|
|
#if os(tvOS)
|
|
return 600
|
|
#else
|
|
return .infinity
|
|
#endif
|
|
}
|
|
|
|
var scrollViewShowsIndicators: Bool {
|
|
#if !os(tvOS)
|
|
true
|
|
#else
|
|
false
|
|
#endif
|
|
}
|
|
}
|
|
|
|
struct VeticalCells_Previews: PreviewProvider {
|
|
static var previews: some View {
|
|
VerticalCells(items: ContentItem.array(of: Array(repeating: Video.fixture, count: 30)))
|
|
.injectFixtureEnvironmentObjects()
|
|
}
|
|
}
|