with #745 I left som testing changes in the PR that resulted in currentChapter index not being updated. This is fixed now.
Also, the ScrollViewReader waiter 0.5s before jumping to the current Chapter. So it is always drawn correctly.
Signed-off-by: Toni Förster <toni.foerster@gmail.com>
Invidious now reports the actual resolution and doesn’t hardcode them anymore.
See: https://github.com/iv-org/invidious/pull/4586
- Extended the list of possible resolutions in the StreamModel
- trigger videoLoadFailureHandler if no streams are available
- more logging for backend.bestPlayable
Signed-off-by: Toni Förster <toni.foerster@gmail.com>
This should circumvent edge cases where videos are marked as watch when they failed to play back.
Fixes#660
Signed-off-by: Toni Förster <toni.foerster@gmail.com>
- ThumbnailsModel optionally returns the quality
- Have constants for 4:3 and 16:9 aspect ratio
- Add high quality options for thumbnails
- Rename Highest quality to Best quality
- make 4:3 thumbnails fill the VideoCell
- use .maxes instead of .maxresdefault (the latter sometimes returns white images)
Signed-off-by: Toni Förster <toni.foerster@gmail.com>
fixes#691
add `--initial-audio-sync=<yes|no>` to MPV settings. Might fix#690 but needs to be toggled by the user. We leave the standard settings.
Also added links to the icons on macOS.
We don't test every single stream anymore. If we get an 200, 206 or 403 we immediately stop testing streams. Unknown streams are also skipped. This speeds up starting playback, since we don'T have to wait for the network anymore.
Invidious, by design, has no images attached to chapters, in contrast to Piped.
Since the majority of videos with chapters don't have chapter-specific images and only use the videos' thumbnail, there is no difference here when compared to Piped's native thumbnail support.
New options for captions in `Settings-Player`:
- Always show captions
- Default language
User can now select whether they want to show captions automatically when the video starts, and select the language.
Captions selector now shows proper name -> `English (en)` instead of only `en`
`cache-pause-initial` status can now be selected by the user.
Also, on macOS and iOS, a link next to the option leads the user to the info on the mpv website.
fixes#674
I accidentally broke PiP when using MPV. While testing this, I noticed that PiP sometimes does not start, so I tried to make MPV to PiP a bit more robust.
This gives a huge increase in perceived performance. The UI is now much more responsive since some tasks are run in the background and don't block the UI anymore.
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.
This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.
Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.
This should fix numerous playback issues: #666, #626, #590, #585, #498, #457, #400
HLS: try matching the set resolution. This works okay with AVPlayer. With MPV it is hit and miss, most of the time MPV targets the highest available bitrate, instead of the set bitrate.
AVPlayer now supports higher resolution up to 1080p60.
This makes sure that HLS Streams can be compared with non HLS streams, otherwise HLS would have been the first selected since the maxResolution.value might have been higher then what could actually be the highest resolution served.
When a user taps on a chapter, the pop now also shows the name of the chapter. The chapters are now marked in AppRedColor instead of orange.
This is based on PR #639
That one needs to be merged first before this one can go in.
- The order of the formats can now be changed in the Quality Settings.
- sortingOrder is now part of QualitiyProfile.
- bestPlayable is now part of PlayerBackend.
- hls and stream aren't treated as unknown anymore.
After the video has ended, hitting play restarts the video from the beginning
fixes#449
If I understand the issue correctly, however, videos can now be played again without hitting the "Start from the beginning" button.
When the time stamp for the last segment is greater the duration currently the video pauses. This interferes with PR #646.
Now instead of pausing we jump to the duration (end time) of the video instead.
Currently, when leaving PiP the backend doesn't switch to the one that was used before starting PiP.
Now, when the backend was MPV, it switches back to it after leaving PiP.
This should reduce the number of falsely matched chapters, e.g., when time-code-like numbers appear in the middle of the text, like 16:9 or sports results.
It also checks for chapters that have an end time and omits the end time code from the title.
Track lists in music videos are now also properly displayed as chapters.
- time update notifications work for both backends
- only init mpv timers when mpv is the active backend
- move notification extension to playerbackend
