mirror of
https://github.com/yattee/yattee.git
synced 2025-11-13 13:48:48 +00:00
Optimize SwiftUI performance throughout the app
This commit addresses multiple SwiftUI performance bottlenecks identified through code analysis, focusing on view rendering efficiency, list performance, and memory usage optimization. Key improvements: - HomeView: Optimize async task management using structured concurrency with async let to handle multiple Defaults updates in a single task - VideoCell: Remove GeometryReader from VideoCellThumbnail to eliminate layout thrashing; change @ObservedObject to computed property for shared ThumbnailsModel - ThumbnailView: Cache URL extension computation in init() instead of recalculating on every body evaluation - FavoriteItemView: Replace filter().prefix() with early-exit loop and capacity reservation for significant performance gain on large lists - ContentItemView: Optimize FetchRequest creation with direct predicate construction only for video items, empty predicate for others - VideoPlayerView: Fix playerSize didSet trigger by moving updateSidebarQueue() calls to explicit onChange/onAppear handlers - FeedView: Replace .unique() with Set-based deduplication for O(n) performance and reduced allocations - VerticalCells: Remove expensive sorting on every redraw; items should be pre-sorted from source These optimizations follow SwiftUI best practices by minimizing expensive computations in view bodies, caching computed values, using efficient data structures, and avoiding unnecessary redraws and layout passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -475,18 +475,14 @@ struct VideoCell: View {
|
||||
|
||||
struct VideoCellThumbnail: View {
|
||||
let video: Video
|
||||
@ObservedObject private var thumbnails = ThumbnailsModel.shared
|
||||
private var thumbnails: ThumbnailsModel { .shared }
|
||||
|
||||
var body: some View {
|
||||
GeometryReader { geometry in
|
||||
let (url, quality) = thumbnails.best(video)
|
||||
let aspectRatio = (quality == .default || quality == .high) ? Constants.aspectRatio4x3 : Constants.aspectRatio16x9
|
||||
let (url, quality) = thumbnails.best(video)
|
||||
let aspectRatio = (quality == .default || quality == .high) ? Constants.aspectRatio4x3 : Constants.aspectRatio16x9
|
||||
|
||||
ThumbnailView(url: url)
|
||||
.aspectRatio(aspectRatio, contentMode: .fill)
|
||||
.frame(width: geometry.size.width, height: geometry.size.height)
|
||||
.clipped()
|
||||
}
|
||||
ThumbnailView(url: url)
|
||||
.aspectRatio(aspectRatio, contentMode: .fill)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user