Mirrored_Repos/yattee
1
0
Fork 0
mirror of https://github.com/yattee/yattee.git synced 2026-07-20 14:22:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix download completion crash from stale array index across await

Browse Source 
completeMultiFileDownload captured an index via firstIndex, then awaited a
detached file-size calculation. Another concurrently-completing download could
mutate activeDownloads during that suspension, leaving the index stale and
crashing in Array.remove(at:) with an out-of-bounds index. Remove the download
by identity instead.

Fixes a SIGTRAP seen in TestFlight build 261 (5 reports).
This commit is contained in:
Arkadiusz Fal
2026-05-11 22:50:16 +02:00
parent f74659e903
commit ec5ac944c4
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Yattee/Services/Downloads/DownloadManager+Execution.swift
View File

@@ -705,8 +705,11 @@ extension DownloadManager {
download.totalBytes = totalBytes download.totalBytes = totalBytes
download.downloadedBytes = totalBytes download.downloadedBytes = totalBytes
// Move to completed // Move to completed. Remove by identity rather than the captured `index`:
activeDownloads.remove(at: index) // the `await` above is a suspension point during which another completing
// download may have mutated `activeDownloads`, leaving `index` stale and
// making `remove(at:)` crash with an out-of-bounds index.
activeDownloads.removeAll { $0.id == downloadID }
completedDownloads.insert(download, at: 0) completedDownloads.insert(download, at: 0)
// Update cached Sets // Update cached Sets