mirror of
https://github.com/yattee/yattee.git
synced 2026-07-21 06:42:01 +00:00
Make CloudKit apply path scope-aware and re-upload local-newer merges
CloudKit record names carry a source scope suffix so the same channel or video ID can exist under different sources, but the apply path matched local entities by bare ID: incoming records could merge into an entity from a different scope, and a remote deletion of one scope deleted every local entity with that ID and cascaded scoped deletions for all other scopes back to CloudKit. - Match local entities on the full mapper-derived record name when merging incoming records, materializing records for upload, and applying remote deletions. - Remote deletions now remove only the matching entity and no longer queue CloudKit deletions (no echo, no cross-scope cascade). - Insert dedupe for CloudKit-applied records is scope-aware, so a same-ID record from a different source inserts instead of being silently dropped. Remotely added bookmarks also update the fast-lookup cache immediately. - When conflict resolution during a fetch keeps newer local data, the merge result is queued for upload; previously the server (and other devices) kept the stale version unless the entity was edited again. Strict timestamp comparisons prevent re-upload ping-pong between devices.
This commit is contained in:
@@ -300,14 +300,34 @@ extension DataManager {
|
||||
let descriptor = FetchDescriptor<RecentChannel>(
|
||||
predicate: #Predicate { $0.channelID == channelID }
|
||||
)
|
||||
|
||||
|
||||
return try? modelContext.fetch(descriptor).first
|
||||
}
|
||||
|
||||
|
||||
/// Gets all recent channels matching a channel ID. The same ID can exist
|
||||
/// under multiple source scopes.
|
||||
func recentChannelEntries(forChannelID channelID: String) -> [RecentChannel] {
|
||||
let descriptor = FetchDescriptor<RecentChannel>(
|
||||
predicate: #Predicate { $0.channelID == channelID }
|
||||
)
|
||||
return (try? modelContext.fetch(descriptor)) ?? []
|
||||
}
|
||||
|
||||
/// Deletes a recent channel without queueing a CloudKit deletion.
|
||||
/// Used by CloudKitSyncEngine when applying remote deletions.
|
||||
func deleteRecentChannelEntry(_ channel: RecentChannel) {
|
||||
modelContext.delete(channel)
|
||||
save()
|
||||
NotificationCenter.default.post(name: .recentChannelsDidChange, object: nil)
|
||||
}
|
||||
|
||||
/// Inserts a recent channel (for CloudKit sync).
|
||||
func insertRecentChannel(_ recentChannel: RecentChannel) {
|
||||
// Check for duplicates by channelID
|
||||
if recentChannelEntry(forChannelID: recentChannel.channelID) == nil {
|
||||
// Check for duplicates within the same source scope - the same
|
||||
// channel ID can legitimately exist under different sources
|
||||
let scopeSuffix = recentChannel.sourceScopeSuffix
|
||||
let existing = recentChannelEntries(forChannelID: recentChannel.channelID)
|
||||
if !existing.contains(where: { $0.sourceScopeSuffix == scopeSuffix }) {
|
||||
modelContext.insert(recentChannel)
|
||||
save()
|
||||
}
|
||||
@@ -467,16 +487,62 @@ extension DataManager {
|
||||
let descriptor = FetchDescriptor<RecentPlaylist>(
|
||||
predicate: #Predicate { $0.playlistID == playlistID }
|
||||
)
|
||||
|
||||
|
||||
return try? modelContext.fetch(descriptor).first
|
||||
}
|
||||
|
||||
|
||||
/// Gets all recent playlists matching a playlist ID. The same ID can
|
||||
/// exist under multiple source scopes.
|
||||
func recentPlaylistEntries(forPlaylistID playlistID: String) -> [RecentPlaylist] {
|
||||
let descriptor = FetchDescriptor<RecentPlaylist>(
|
||||
predicate: #Predicate { $0.playlistID == playlistID }
|
||||
)
|
||||
return (try? modelContext.fetch(descriptor)) ?? []
|
||||
}
|
||||
|
||||
/// Deletes a recent playlist without queueing a CloudKit deletion.
|
||||
/// Used by CloudKitSyncEngine when applying remote deletions.
|
||||
func deleteRecentPlaylistEntry(_ playlist: RecentPlaylist) {
|
||||
modelContext.delete(playlist)
|
||||
save()
|
||||
NotificationCenter.default.post(name: .recentPlaylistsDidChange, object: nil)
|
||||
}
|
||||
|
||||
/// Inserts a recent playlist (for CloudKit sync).
|
||||
func insertRecentPlaylist(_ recentPlaylist: RecentPlaylist) {
|
||||
// Check for duplicates by playlistID
|
||||
if recentPlaylistEntry(forPlaylistID: recentPlaylist.playlistID) == nil {
|
||||
// Check for duplicates within the same source scope - the same
|
||||
// playlist ID can legitimately exist under different sources
|
||||
let scopeSuffix = recentPlaylist.sourceScopeSuffix
|
||||
let existing = recentPlaylistEntries(forPlaylistID: recentPlaylist.playlistID)
|
||||
if !existing.contains(where: { $0.sourceScopeSuffix == scopeSuffix }) {
|
||||
modelContext.insert(recentPlaylist)
|
||||
save()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Source Scope
|
||||
|
||||
private extension RecentChannel {
|
||||
/// Record-name scope suffix used to distinguish same-ID entities across sources.
|
||||
var sourceScopeSuffix: String {
|
||||
SourceScope.from(
|
||||
sourceRawValue: sourceRawValue,
|
||||
globalProvider: nil,
|
||||
instanceURLString: instanceURLString,
|
||||
externalExtractor: nil
|
||||
).recordNameSuffix
|
||||
}
|
||||
}
|
||||
|
||||
private extension RecentPlaylist {
|
||||
/// Record-name scope suffix used to distinguish same-ID entities across sources.
|
||||
var sourceScopeSuffix: String {
|
||||
SourceScope.from(
|
||||
sourceRawValue: sourceRawValue,
|
||||
globalProvider: nil,
|
||||
instanceURLString: instanceURLString,
|
||||
externalExtractor: nil
|
||||
).recordNameSuffix
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user