mirror of
https://github.com/yattee/yattee.git
synced 2026-07-21 06:42:01 +00:00
Make CloudKit apply path scope-aware and re-upload local-newer merges
CloudKit record names carry a source scope suffix so the same channel or video ID can exist under different sources, but the apply path matched local entities by bare ID: incoming records could merge into an entity from a different scope, and a remote deletion of one scope deleted every local entity with that ID and cascaded scoped deletions for all other scopes back to CloudKit. - Match local entities on the full mapper-derived record name when merging incoming records, materializing records for upload, and applying remote deletions. - Remote deletions now remove only the matching entity and no longer queue CloudKit deletions (no echo, no cross-scope cascade). - Insert dedupe for CloudKit-applied records is scope-aware, so a same-ID record from a different source inserts instead of being silently dropped. Remotely added bookmarks also update the fast-lookup cache immediately. - When conflict resolution during a fetch keeps newer local data, the merge result is queued for upload; previously the server (and other devices) kept the stale version unless the entity was edited again. Strict timestamp comparisons prevent re-upload ping-pong between devices.
This commit is contained in:
@@ -119,26 +119,55 @@ extension DataManager {
|
||||
)
|
||||
return try? modelContext.fetch(descriptor).first
|
||||
}
|
||||
|
||||
|
||||
/// Gets all bookmarks matching a video ID. The same ID can exist
|
||||
/// under multiple source scopes; callers that care about a specific
|
||||
/// source must pick the matching entity themselves.
|
||||
func bookmarks(forVideoID videoID: String) -> [Bookmark] {
|
||||
let descriptor = FetchDescriptor<Bookmark>(
|
||||
predicate: #Predicate { $0.videoID == videoID }
|
||||
)
|
||||
return (try? modelContext.fetch(descriptor)) ?? []
|
||||
}
|
||||
|
||||
/// Deletes a single bookmark without queueing a CloudKit deletion.
|
||||
/// Used by CloudKitSyncEngine when applying remote deletions.
|
||||
func deleteBookmark(_ bookmark: Bookmark) {
|
||||
let videoID = bookmark.videoID
|
||||
modelContext.delete(bookmark)
|
||||
save()
|
||||
|
||||
// Keep the fast-lookup cache accurate; another scope may still
|
||||
// have a bookmark with this video ID
|
||||
if self.bookmark(for: videoID) == nil {
|
||||
cachedBookmarkedVideoIDs.remove(videoID)
|
||||
}
|
||||
TopShelfSnapshotWriter.writeBookmarks(dataManager: self)
|
||||
}
|
||||
|
||||
/// Inserts a bookmark into the database.
|
||||
/// Used by CloudKitSyncEngine for applying remote bookmarks.
|
||||
func insertBookmark(_ bookmark: Bookmark) {
|
||||
// Check for duplicates
|
||||
// Check for duplicates within the same source scope - the same
|
||||
// video ID can legitimately exist under different sources
|
||||
let videoID = bookmark.videoID
|
||||
let descriptor = FetchDescriptor<Bookmark>(
|
||||
predicate: #Predicate { $0.videoID == videoID }
|
||||
)
|
||||
|
||||
let scopeSuffix = bookmark.sourceScopeSuffix
|
||||
|
||||
do {
|
||||
let existing = try modelContext.fetch(descriptor)
|
||||
if existing.isEmpty {
|
||||
if !existing.contains(where: { $0.sourceScopeSuffix == scopeSuffix }) {
|
||||
modelContext.insert(bookmark)
|
||||
save()
|
||||
cachedBookmarkedVideoIDs.insert(videoID)
|
||||
}
|
||||
} catch {
|
||||
// Insert anyway if we can't check
|
||||
modelContext.insert(bookmark)
|
||||
save()
|
||||
cachedBookmarkedVideoIDs.insert(videoID)
|
||||
}
|
||||
TopShelfSnapshotWriter.writeBookmarks(dataManager: self)
|
||||
}
|
||||
@@ -180,3 +209,17 @@ extension DataManager {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Source Scope
|
||||
|
||||
private extension Bookmark {
|
||||
/// Record-name scope suffix used to distinguish same-ID entities across sources.
|
||||
var sourceScopeSuffix: String {
|
||||
SourceScope.from(
|
||||
sourceRawValue: sourceRawValue,
|
||||
globalProvider: globalProvider,
|
||||
instanceURLString: instanceURLString,
|
||||
externalExtractor: externalExtractor
|
||||
).recordNameSuffix
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user