Mirrored_Repos/yattee
1
0
Fork 0
mirror of https://github.com/yattee/yattee.git synced 2026-07-21 14:52:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead legacy-import pipeline and unused LegacyAccount.password

Browse Source 
The manual account-import flow made the old silent instance-import
pipeline unreachable. Drop the orphaned parsing, reachability checks,
batch import, result/error types, and the old import row view, plus the
httpClient dependency they were the only consumer of. Also remove the
LegacyAccount.password field, which was parsed but never read.
This commit is contained in:
Arkadiusz Fal
2026-05-17 19:29:21 +02:00
parent bde80bfef1
commit c4bcfd1211
4 changed files with 3 additions and 417 deletions
Download Patch File Download Diff File Expand all files Collapse all files

100
Yattee/Services/Migration/LegacyDataModels.swift
View File

@@ -100,9 +100,6 @@ struct LegacyAccount: Sendable {
/// Stored username/email, when present in UserDefaults.
let username: String
/// Password value from very old defaults exports, if present.
let password: String?
/// Parses a dictionary from v1 UserDefaults format.
/// - Parameter dictionary: The serialized account dictionary
/// - Returns: A LegacyAccount if parsing succeeds, nil otherwise
@@ -115,57 +112,17 @@ struct LegacyAccount: Sendable {
let instanceID = dictionary["instanceID"] as? String ?? ""
let name = dictionary["name"] as? String ?? ""
let password = dictionary["password"] as? String
return LegacyAccount(
id: id,
instanceID: instanceID,
name: name,
apiURL: apiURL,
username: username,
password: password?.isEmpty == true ? nil : password
username: username
)
}
}
// MARK: - Legacy Import Item
/// Represents an instance to be imported from v1 data.
/// Only instances are imported - users need to re-add their accounts after import.
struct LegacyImportItem: Identifiable, Sendable {
/// New UUID for UI identification
let id: UUID
/// The original v1 instance ID
let legacyInstanceID: String
/// The type of instance (Invidious or Piped)
let instanceType: InstanceType
/// The instance URL
let url: URL
/// User-defined name for the instance
let name: String?
/// Whether this instance proxies videos
var proxiesVideos: Bool = false
/// Whether this item is selected for import
var isSelected: Bool = true
/// Current reachability status
var reachabilityStatus: ReachabilityStatus = .unknown
/// Display name for the UI
var displayName: String {
if let name, !name.isEmpty {
return name
}
return url.host ?? url.absoluteString
}
}
// MARK: - Legacy Account Import Item
/// Represents a legacy account that can be re-created by signing in to v2.
@@ -216,58 +173,3 @@ struct LegacyAccountImportItem: Identifiable, Sendable {
return url.host ?? url.absoluteString
}
}
// MARK: - Reachability Status
/// Status of an instance's reachability check.
enum ReachabilityStatus: Sendable {
/// Not yet checked
case unknown
/// Currently checking
case checking
/// Instance is reachable
case reachable
/// Instance is unreachable
case unreachable
}
// MARK: - Migration Result
/// Result of an import operation.
struct MigrationResult {
/// Items that were successfully imported
let succeeded: [LegacyImportItem]
/// Items that failed to import with their errors
let failed: [(item: LegacyImportItem, error: MigrationError)]
/// Items that were skipped because they already exist
let skippedDuplicates: [LegacyImportItem]
/// Whether all selected items were successfully imported
var isFullSuccess: Bool {
failed.isEmpty
}
/// Total number of items processed
var totalProcessed: Int {
succeeded.count + failed.count + skippedDuplicates.count
}
}
// MARK: - Migration Error
/// Errors that can occur during migration.
enum MigrationError: LocalizedError, Sendable {
case invalidURL
case unknown(String)
var errorDescription: String? {
switch self {
case .invalidURL:
return String(localized: "migration.error.invalidURL")
case .unknown(let message):
return message
}
}
}