Mirrored_Repos/yattee
1
0
Fork 0
mirror of https://github.com/yattee/yattee.git synced 2025-11-16 06:58:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add retry mechanism for MPV file load errors

Browse Source 
Implemented automatic retry logic with exponential backoff (2, 4, 6 seconds) when file loading fails in MPVBackend. Retries up to 3 times before showing error to user. Retry state is properly reset on successful loads.
This commit is contained in:
Arkadiusz Fal
2025-11-14 18:58:27 +01:00
parent 11a2ef207c
commit b6df73f949
1 changed files with 55 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
Model/Player/Backends/MPVBackend.swift
View File

@@ -97,6 +97,12 @@ final class MPVBackend: PlayerBackend {
var controlsUpdates = false
private var timeObserverThrottle = Throttle(interval: 2)
// Retry mechanism
private var retryCount = 0
private let maxRetries = 3
private var currentRetryStream: Stream?
private var currentRetryVideo: Video?
var suggestedPlaybackRates: [Double] {
[0.25, 0.33, 0.5, 0.67, 0.75, 1, 1.25, 1.5, 1.75, 2, 3, 4]
@@ -218,6 +224,10 @@ final class MPVBackend: PlayerBackend {
}
func playStream(_ stream: Stream, of video: Video, preservingTime: Bool, upgrading: Bool) {
// Store stream and video for potential retries
currentRetryStream = stream
currentRetryVideo = video
#if !os(macOS)
if model.presentingPlayer {
DispatchQueue.main.async {
@@ -582,6 +592,8 @@ final class MPVBackend: PlayerBackend {
onFileLoaded?()
startClientUpdates()
onFileLoaded = nil
// Reset retry state on successful load
resetRetryState()
case MPV_EVENT_PROPERTY_CHANGE:
let dataOpaquePtr = OpaquePointer(event.pointee.data)
@@ -597,6 +609,8 @@ final class MPVBackend: PlayerBackend {
onFileLoaded?()
startClientUpdates()
onFileLoaded = nil
// Reset retry state on successful playback restart
resetRetryState()
case MPV_EVENT_VIDEO_RECONFIG:
model.updateAspectRatio()
@@ -610,10 +624,7 @@ final class MPVBackend: PlayerBackend {
if reason != MPV_END_FILE_REASON_STOP {
DispatchQueue.main.async { [weak self] in
guard let self else { return }
NavigationModel.shared.presentAlert(title: "Error while opening file")
self.model.closeCurrentItem(finished: true)
self.getTimeUpdates()
self.eofPlaybackModeAction()
self.handleFileLoadError()
}
} else {
DispatchQueue.main.async { [weak self] in self?.handleEndOfFile() }
@@ -630,6 +641,46 @@ final class MPVBackend: PlayerBackend {
}
eofPlaybackModeAction()
}
private func handleFileLoadError() {
guard let stream = currentRetryStream, let video = currentRetryVideo else {
// No stream info available, show error immediately
NavigationModel.shared.presentAlert(title: "Error while opening file")
model.closeCurrentItem(finished: true)
getTimeUpdates()
eofPlaybackModeAction()
return
}
if retryCount < maxRetries {
retryCount += 1
let delay = TimeInterval(retryCount * 2) // 2, 4, 6 seconds
logger.warning("File load failed. Retry attempt \(retryCount) of \(maxRetries) after \(delay) seconds...")
DispatchQueue.main.asyncAfter(deadline: .now() + delay) { [weak self] in
guard let self else { return }
self.logger.info("Retrying file load (attempt \(self.retryCount))...")
self.playStream(stream, of: video, preservingTime: true, upgrading: false)
}
} else {
// All retries exhausted, show error
logger.error("File load failed after \(maxRetries) retry attempts")
NavigationModel.shared.presentAlert(title: "Error while opening file")
model.closeCurrentItem(finished: true)
getTimeUpdates()
eofPlaybackModeAction()
// Reset retry counter for next attempt
resetRetryState()
}
}
private func resetRetryState() {
retryCount = 0
currentRetryStream = nil
currentRetryVideo = nil
}
func setNeedsDrawing(_ needsDrawing: Bool) {
client?.setNeedsDrawing(needsDrawing)